[asterisk-bugs] [Asterisk 0017235]: [patch] asterisk dsp always reports detected DTMF length to be 0ms

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17235 
====================================================================== 
Reported By:                frawd
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17235
Category:                   Core/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1337 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-23 10:21 CDT
Last Modified:              2010-04-27 16:41 CDT
====================================================================== 
Summary:                    [patch] asterisk dsp always reports detected DTMF
length to be 0ms
Description: 
The attached patch makes the DSP report the correct length for DTMF
detected in the audio.

Tested with DAHDI channels (FXS, FXO, ISDN PRI) and SIP channels
configured as "inband".
====================================================================== 

---------------------------------------------------------------------- 
 (0121034) dimas (reporter) - 2010-04-27 16:41
 https://issues.asterisk.org/view.php?id=17235#c121034 
---------------------------------------------------------------------- 
Strictly speaking, your patch just adds the length. It does not add "the
correct length" as you write.

First of all this is because of current_digits buffer. If two DTMF digits
are detected within single audio frame, they are buffered using this
buffer. These will be unbuffered and returned during next calls to
dsp_process and the time information from tv_now is meaningless in this
case.

Like Russel I wonder what are you trying to fix because Asterisk should
live ok with zero len DTMFs - it will emulate one of minimum length
anyway.

I'm afraid that in order to provide correct length information dsp.c needs
more serios changes than ones you suggested. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-27 16:41 dimas          Note Added: 0121034                          
======================================================================