[asterisk-bugs] [Asterisk 0017235]: [patch] asterisk dsp always reports detected DTMF length to be 0ms

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17235 
====================================================================== 
Reported By:                frawd
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17235
Category:                   Core/General
Reproducibility:            always
Severity:                   trivial
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.6.2.7-rc2 
JIRA:                       SWP-1337 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-04-23 10:21 CDT
Last Modified:              2010-04-27 09:53 CDT
====================================================================== 
Summary:                    [patch] asterisk dsp always reports detected DTMF
length to be 0ms
Description: 
The attached patch makes the DSP report the correct length for DTMF
detected in the audio.

Tested with DAHDI channels (FXS, FXO, ISDN PRI) and SIP channels
configured as "inband".
====================================================================== 

---------------------------------------------------------------------- 
 (0120973) frawd (reporter) - 2010-04-27 09:53
 https://issues.asterisk.org/view.php?id=17235#c120973 
---------------------------------------------------------------------- 
It depends what would be considered more optimized between:

- adding one more variable (dtmf_tv) in dsp struct, and initializing it
only when necessary (when DSP_FEATURE_DIGIT_DETECT is set).
or
- reusing dtmf_began and having to initialize it to gettimeofday
(ast_tvnow) even if not needed (when DSP_FEATURE_DIGIT_DETECT is unset).

I can upload a patch reusing dtmf_began if needed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-27 09:53 frawd          Note Added: 0120973                          
======================================================================