[asterisk-bugs] [LibPRI 0014378]: [patch] Two odd error messages on BRI PtMP lines

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14378 
====================================================================== 
Reported By:                timking
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   14378
Category:                   General
Reproducibility:            random
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-01-31 11:41 CST
Last Modified:              2010-04-26 14:39 CDT
====================================================================== 
Summary:                    [patch] Two odd error messages on BRI PtMP lines
Description: 
I am running libpri-1.4.9 in a production environment. I notice the
following in the logs, apparently at random.
[Jan 30 15:33:11] ERROR[7615] chan_dahdi.c: XXX Message longer than it
should be?? XXX
[Jan 30 15:33:15] ERROR[7615] chan_dahdi.c: XXX Message longer than it
should be?? XXX
[Jan 30 15:33:50] ERROR[7614] chan_dahdi.c: XXX Message longer than it
should be?? XXX
[Jan 30 15:33:54] ERROR[7614] chan_dahdi.c: XXX Message longer than it
should be?? XXX
[Jan 30 15:34:29] ERROR[7615] chan_dahdi.c: !! < Unknown IE 224 (cs0, len
= 1)
====================================================================== 

---------------------------------------------------------------------- 
 (0120934) svnbot (reporter) - 2010-04-26 14:39
 https://issues.asterisk.org/view.php?id=14378#c120934 
---------------------------------------------------------------------- 
Repository: libpri
Revision: 1674

U   branches/1.4/q931.c

------------------------------------------------------------------------
r1674 | rmudgett | 2010-04-26 14:39:29 -0500 (Mon, 26 Apr 2010) | 16 lines

Garbage on the end of Q.931 messages causing calls to fail to connect.

The DAHDI driver had a bug where an extra byte appeared on the end of
Q.931 messages.  This garbage byte caused the message to be discarded with
the diagnostic "XXX Message longer than it should be??  XXX".  The Q.931
message will no longer be discarded if there were earlier ie's in the
message.

This patch also addresses the potential problem of reading beyond the
buffer when trying to parse the garbage data.

Thanks to roeften for the base patch.

(closes issue https://issues.asterisk.org/view.php?id=14378)
Reported by: timking

------------------------------------------------------------------------

http://svn.digium.com/view/libpri?view=rev&revision=1674 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-26 14:39 svnbot         Checkin                                      
2010-04-26 14:39 svnbot         Note Added: 0120934                          
======================================================================