[asterisk-bugs] [Asterisk 0016660]: [patch] [regression] [patch] chan_sip does not check other mailboxes on AST_EVENT_MWI

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16660 
====================================================================== 
Reported By:                rain
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16660
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.1 
JIRA:                       SWP-767 
Regression:                 Yes 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-01-20 13:51 CST
Last Modified:              2010-04-13 13:13 CDT
====================================================================== 
Summary:                    [patch] [regression] [patch] chan_sip does not check
other mailboxes on AST_EVENT_MWI
Description: 
When chan_sip receives an AST_EVENT_MWI, the callback will always believe
the message counters in the event
(AST_EVENT_IE_NEWMSGS/AST_EVENT_IE_OLDMSGS); however, if the peer receiving
the event has voicemail messages in a different mailbox that it is ALSO
subscribed to, these counters will be wrong (since the callback makes no
attempt to check other mailboxes if event is not NULL.)

The easiest solution to this problem seems to be ignoring the IEs in the
AST_EVENT_MWI event and going right to get_cached_mwi, which appears to
check for MWI events on all subscribed inboxes.  The attached patch does
this, but this caused some of my phones to incorrectly show messages
waiting when I restarted Asterisk.  From some debug logging I added locally
to get_cached_mwi, it seems that ast_event_get_cached() can return an MWI
event with incorrect data in the NEWMSGS/OLDMSGS IEs while app_voicemail is
loading (e.g. 1 new, 0 old), although a cache query for the same
mailbox at context will (accurately) return 0/7 a moment later.  (I'm trying
to debug that.)

Disclaimer on file.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0017153 chan_sip sends to peer mwi notify  for ...
====================================================================== 

---------------------------------------------------------------------- 
 (0120338) Jamuel (reporter) - 2010-04-13 13:13
 https://issues.asterisk.org/view.php?id=16660#c120338 
---------------------------------------------------------------------- 
RAIN -- THANKS.  I will apply that patch and confirm.  Will probably take a
day or so to get the patch in.

On a related note -- Bug: 17153 my solution of bypassing the event api
seems to being working.

I'm glad to hear that I should be able to revert my patch and apply the
one-liner that you suggested.

Longer term do you suggest applying the patch from 16607 and then applying
the patches you've provided here in 16660? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-13 13:13 Jamuel         Note Added: 0120338                          
======================================================================