[asterisk-bugs] [Asterisk 0016908]: [patch] SIP autocreate peers registered when request to unregister

[Asterisk Bug Tracker]

The following issue is now READY FOR TESTING. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16908 
====================================================================== 
Reported By:                kkm
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16908
Category:                   Channels/chan_sip/Registration
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.2.8
Asterisk Version:           SVN 
JIRA:                       SWP-1004 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.2 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2010-02-26 00:07 CST
Last Modified:              2010-04-12 15:48 CDT
====================================================================== 
Summary:                    [patch] SIP autocreate peers registered when request
to unregister
Description: 
When autocreate is enabled and a peer is *not* registered, and such a peer
sends a REGISTER message with the "Expires: 0" header (to indicate it wants
to unregister), the peer is apparently registered and then partially(?)
unregistered:
 * There is a NOTICE-level option poke message;
 * The sequence of PeerStatus manager events shows 3 events:
   1. Unregistered (that's expected)
   2. Registered (that's not)
   3. Reachable 


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0016033 [patch] Autocreated peers not deleted w...
====================================================================== 

---------------------------------------------------------------------- 
 (0120303) tilghman (administrator) - 2010-04-12 15:48
 https://issues.asterisk.org/view.php?id=16908#c120303 
---------------------------------------------------------------------- 
I think this patch should fix the situation.  What it does is to check the
value of the Expires header (after it detects the presence of a duplicate
message) before trying to load the peer into memory.  If it's set to expire
the peer and the peer isn't already in memory, then it will just issue a
blanket 200 OK and exit without loading the peer.  I believe this should
fix the issue you are seeing. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-12 15:48 tilghman       Note Added: 0120303                          
2010-04-12 15:48 tilghman       Status                   acknowledged => ready
for testing
======================================================================