[asterisk-bugs] [Asterisk 0017125]: [patch] Make transfer calls more pattern friendly

Asterisk Bug Tracker noreply at bugs.digium.com
Mon Apr 5 14:40:13 CDT 2010


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=17125 
====================================================================== 
Reported By:                dmartin
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   17125
Category:                   Applications/General
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 255751 
Request Review:              
====================================================================== 
Date Submitted:             2010-04-01 14:15 CDT
Last Modified:              2010-04-05 14:40 CDT
====================================================================== 
Summary:                    [patch] Make transfer calls more pattern friendly
Description: 
Let these two patterns in a context:

_2XX => {
// do something
};

_X. => {
//do something else
};

If in a call between users in this context, we want to transfer the call
to a number like, eg, 210, then it match _X. pattern instead of _2XX. and
effectively tries to call extension '2'.

Tracing the code I found this may be because ast_app_dtget() looks for a
match on the dialplan in every key stroke.

This patch avoid this and only tries to transfer the call when a timeout
is reached (transferdigittimeout) or when the transferer party dials #.
====================================================================== 

---------------------------------------------------------------------- 
 (0120140) dmartin (reporter) - 2010-04-05 14:40
 https://issues.asterisk.org/view.php?id=17125#c120140 
---------------------------------------------------------------------- 
I'm sorry, it worked for me, so I submitted the patch. And sorry about the
example, I'm seeing that I was mistaken. It won't change anything, but I
will try to explain a better example.

Let the context with the patterns above, ( _2XX and _X. ) 

trying to transfer the call to number '91777' will stop accepting digits
on '9' and will match _X. so it won't never reach '91777' but '9', being
that dialplan absolutely compliant (I have it in fact on my dialplan to
send all the calls to unmatched numbers to a trunk).

I'm with you on this patch would change Asterisk behaviour, but didn't
find anything that can be broken  at the time of writing.

Feel free to discard the patch and close the bug, but I'm still thinking
that this is a (minor) Asterisk issue, not my dialplan's. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2010-04-05 14:40 dmartin        Note Added: 0120140                          
======================================================================




More information about the asterisk-bugs mailing list