[asterisk-bugs] [Asterisk 0014418]: [patch] If a SIP URI is resolved with SRV records, the port must no be in the Request-URI

Wed Sep 30 18:11:17 CDT 2009

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14418 
====================================================================== 
Reported By:                klaus3000
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   14418
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           1.4.23 
JIRA:                        
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-02-06 04:04 CST
Last Modified:              2009-09-30 18:11 CDT
====================================================================== 
Summary:                    [patch] If a SIP URI is resolved with SRV records,
the port must no be in the Request-URI
Description: 
Hi!

If Asterisk resolves a SIP domain by SRV, it should use the resolved
IP:port for sending the transport only, not changing the RURI.

E.g. if Asterisk sends a request to sip:user at mydomain.com and resolves
using SRV, then the requests URI must not contain the port.

    -- Now forwarding SIP/u+437206200730153-b7058588 to
'SIP/2 at app.innofon.at' (thanks to SIP/u+437206200730151-08ef44e8)
    -- ast_get_srv: SRV lookup for '_sip._udp.app.innofon.at' mapped to
host app.innofon.at, port 5160
Audio is at 81.16.153.184 port 12012
Adding codec 0x4 (ulaw) to SDP
Adding codec 0x8 (alaw) to SDP
Adding codec 0x400 (ilbc) to SDP
Adding codec 0x2 (gsm) to SDP
Adding non-codec 0x1 (telephone-event) to SDP
Reliably Transmitting (no NAT) to 81.16.153.184:5160:
INVITE sip:2 at app.innofon.at:5160 SIP/2.0
Via: SIP/2.0/UDP 81.16.153.184:5160;branch=z9hG4bK462e8ee7;rport
From: "3 (SNOM 200)" <sip:3 at 81.16.153.184:5160>;tag=as054e6763
To: <sip:2 at app.innofon.at:5160>
Contact: <sip:3 at 81.16.153.184:5160>
Call-ID: 455000696c1b0a0829b83b384670155e at 81.16.153.184
CSeq: 102 INVITE
User-Agent: InnoSIP-app
Max-Forwards: 70
Date: Fri, 06 Feb 2009 09:55:15 GMT
Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY
Supported: replaces
Content-Type: application/sdp
Content-Length: 334

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014419 [patch] Asterisk must not perform SRV l...
====================================================================== 

---------------------------------------------------------------------- 
 (0111685) svnbot (reporter) - 2009-09-30 18:11
 https://issues.asterisk.org/view.php?id=14418#c111685 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 221486

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_sip.c
U   branches/1.6.0/configs/sip.conf.sample

------------------------------------------------------------------------
r221486 | mnicholson | 2009-09-30 18:11:16 -0500 (Wed, 30 Sep 2009) | 24
lines

Merged revisions 221432 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r221432 | mnicholson | 2009-09-30 15:40:20 -0500 (Wed, 30 Sep 2009) | 17
lines

  Merged revisions 221360 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r221360 | mnicholson | 2009-09-30 14:36:06 -0500 (Wed, 30 Sep 2009) |
10 lines

    Fix SRV lookup and Request-URI generation in chan_sip.

    This patch adds a new field "portinuri" to the sip dialog struct and
the sip peer struct.  That field is used during RURI generation to
determine if the port should be included in the RURI.  It is also used in
some places to determine if an SRV lookup should occur.

    (closes issue https://issues.asterisk.org/view.php?id=14418)
    Reported by: klaus3000
    Tested by: klaus3000, mnicholson

    Review: https://reviewboard.asterisk.org/r/369/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=221486 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-30 18:11 svnbot         Note Added: 0111685                          
======================================================================