[asterisk-bugs] [Asterisk 0014340]: [patch] Calls are not matched to correct peer when using callbackextension parameter

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14340 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   14340
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-01-27 04:03 CST
Last Modified:              2009-09-30 11:29 CDT
====================================================================== 
Summary:                    [patch] Calls are not matched to correct peer when
using callbackextension parameter
Description: 
If there are a number of peers with different callbackextension parameters
the incoming calls are not matched to the right peers

for example with two peers as follows
[trunk1]
host=sip.myitsp.com
callbackextension=9991
...
[trunk2]
host=sip.myitsp.com
callbackextension=9992
...

incoming calls to 9991 and to 9992 are both matched to the peer for 9992
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
duplicate of        0014250 [patch] Incoming calls from registratio...
====================================================================== 

---------------------------------------------------------------------- 
 (0111649) Nick_Lewis (reporter) - 2009-09-30 11:29
 https://issues.asterisk.org/view.php?id=14340#c111649 
---------------------------------------------------------------------- 
The proposed patch uses a process of finding a peer with matching ip and
then trying to find one with matching both ip and callbackextension. If the
tighter match is found it tosses the previously found peer. This is not an
efficient approach. There is always a double search whether or not there is
a tight peer match.

It is better to go straight to the search for the tighter match and only
do the ip match if it fails. In that way if there is a tight match (ip and
callbackextension) then the ip search is not required. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-30 11:29 Nick_Lewis     Note Added: 0111649                          
======================================================================