[asterisk-bugs] [LibPRI 0015604]: [patch] Support for called_party_subaddr, currently only calling_party_subaddr is supported

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15604 
====================================================================== 
Reported By:                alecdavis
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   15604
Category:                   NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-07-28 21:51 CDT
Last Modified:              2009-09-28 05:22 CDT
====================================================================== 
Summary:                    [patch] Support for called_party_subaddr, currently
only calling_party_subaddr is supported
Description: 
Looking at q931.c it only has dump_called_party_subaddr
it's missing receive_called_party_subaddr, transmit_called_party_subaddr,
and associated pri_call changes. Maybe more...

The Telecom Specs in NZ suggests that SUB ADDRESS is always on, so doing
"desk to desk" between offices each with an asterisk box over the ISDN
should then be possible, without a whole load of DDI numbers required.

Is there any work beinging done for this?


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0001877 Useful enhancement to chan_zap would be...
====================================================================== 

---------------------------------------------------------------------- 
 (0111405) alecdavis (reporter) - 2009-09-28 05:22
 https://issues.asterisk.org/view.php?id=15604#c111405 
---------------------------------------------------------------------- 
uploaded:
 libpri_subaddr_trunk.diff2.txt
 asterisk_subaddr_trunk.diff2.txt

working from task list of https://issues.asterisk.org/view.php?id=15604#c111377
libpri: don't think I missed anything from list of tasks.
asterisk: all done except for functions, started work on func_callerid.

debug required, as CALLERID(subaddr) isn't being populated....

dialplan code:
exten => 6882,1,NoOp(callingsubaddress = '${CALLINGSUBADDR}'
calledsubaddress = '${CALLEDSUBADDR}')
exten => 6882,n,NoOp(CALLERID DNID='${CALLERID(dnid)}'
DNID_SUBADDR='${CALLERID(dnid-subaddr)}' )
exten => 6882,n,NoOp(CALLERID SUBADDR='${CALLERID(subaddr)}'
SUBADDR_VALID='${CALLERID(subaddr-valid)}' )

console output:
-- Executing [6882 at incoming:1] NoOp("DAHDI/1-1", "callingsubaddress =
'1234' calledsubaddress = '1234'") in new stack
    -- Executing [6882 at incoming:2] NoOp("DAHDI/1-1", "CALLERID DNID='6882'
DNID_SUBADDR='' ") in new stack
    -- Executing [6882 at incoming:3] NoOp("DAHDI/1-1", "CALLERID SUBADDR=''
SUBADDR_VALID='0' ") in new stack

console output with pri intense debug:
setup message as received.

< Message Type: SETUP (5)
< [04 03 80 90 a3]
< Bearer Capability (len= 5) [ Ext: 1  Q.931 Std: 0  Info transfer
capability: Speech (0)
<                              Ext: 1  Trans mode/rate: 64kbps,
circuit-mode (16)
<                                User information layer 1: A-Law (35)
< [18 03 a9 83 81]
< Channel ID (len= 5) [ Ext: 1  IntID: Implicit  Other(PRI)  Spare: 0 
Exclusive  Dchan: 0
<                        ChanSel: As indicated in following octets
<                       Ext: 1  Coding: 0  Number Specified  Channel Type:
3
<                       Ext: 1  Channel: 1 Type: CPE]
< [6c 07 21 81 34 38 36 30 39]
< Calling Number (len= 9) [ Ext: 0  TON: National Number (2)  NPI:
ISDN/Telephony Numbering Plan (E.164/E.163) (1)
<                           Presentation: Presentation permitted, user
number passed network screening (1)  '48609' ]
< [6d 05 80 31 32 33 34]
< Calling Sub-Address (len= 7) [ Ext: 1  Type: NSAP (X.213/ISO 8348 AD2)
(0)  O: 0  '1234' ]
< [70 05 81 36 38 38 32]
< Called Number (len= 7) [ Ext: 1  TON: Unknown Number Type (0)  NPI:
ISDN/Telephony Numbering Plan (E.164/E.163) (1)  '6882' ]
< [71 05 80 35 36 37 38]
< Called Sub-Address (len= 7) [ Ext: 1  Type: NSAP (X.213/ISO 8348 AD2)
(0)  O: 0  '5678' ]
-- Making new call for cr 10
-- Processing Q.931 Call Setup
-- Processing IE 4 (cs0, Bearer Capability)
-- Processing IE 24 (cs0, Channel Identification)
-- Processing IE 108 (cs0, Calling Party Number)
-- Processing IE 109 (cs0, Calling Party Subaddress)
-- Processing IE 112 (cs0, Called Party Number)
-- Processing IE 113 (cs0, Called Party Subaddress)
q931.c:4675 post_handle_q931_message: call 10 on channel 1 enters state 6
(Call Present) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-28 05:22 alecdavis      Note Added: 0111405                          
======================================================================