[asterisk-bugs] [Asterisk 0015879]: [patch] voicemail should mark messages as read by doing an UPDATE instead of an INSERT followed by a DELETE

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15879 
====================================================================== 
Reported By:                KyleK
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15879
Category:                   Applications/app_voicemail/ODBC
Reproducibility:            always
Severity:                   tweak
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.1.6 
JIRA:                        
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 218049 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-10 21:54 CDT
Last Modified:              2009-09-19 23:34 CDT
====================================================================== 
Summary:                    [patch] voicemail should mark messages as read by
doing an UPDATE instead of an INSERT followed by a DELETE
Description: 
I sniffed out that app_voicemail was doing an INSERT to move a message from
Inbox to Old and decided to change it to an UPDATE. I'm running asterisk
1.6.1 svn but I'll try this against trunk in a bit.
====================================================================== 

---------------------------------------------------------------------- 
 (0111044) KyleK (reporter) - 2009-09-19 23:34
 https://issues.asterisk.org/view.php?id=15879#c111044 
---------------------------------------------------------------------- 
I've fixed the formatting, but I'm still pondering race conditions. 
I need to figure out why the /* Delete ALL remaining messages */ block is
there in the first place. 

I'll keep plugging away at this as time permits, and try and get rid of
that second loop. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-19 23:34 KyleK          Note Added: 0111044                          
======================================================================