[asterisk-bugs] [Asterisk 0015151]: [patch] Deadlock On One-legged Transfer [SIP / REPLACES] (Call Pickup)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15151 
====================================================================== 
Reported By:                irroot
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15151
Category:                   Channels/chan_sip/Transfers
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     closed
Target Version:             1.4.27
Asterisk Version:           1.4.24 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-19 08:31 CDT
Last Modified:              2009-09-17 17:07 CDT
====================================================================== 
Summary:                    [patch] Deadlock On One-legged Transfer [SIP /
REPLACES] (Call Pickup)
Description: 
Hi there here is a nasty deadlock on a one legged transfer [SIP /
REPLACES].

the solution is trivial but took me a few hours to pickup the patch is a
patch against clean 1.4.24.1.

the bellow lock dump is from a patched version.

BTW the this is a bit of a joke as im a amputee so me colegues had a field
day.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015143 [patch] Deadlock on chan_sip
====================================================================== 

---------------------------------------------------------------------- 
 (0110908) svnbot (reporter) - 2009-09-17 17:07
 https://issues.asterisk.org/view.php?id=15151#c110908 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 219307

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r219307 | dvossel | 2009-09-17 17:07:56 -0500 (Thu, 17 Sep 2009) | 34
lines

Merged revisions 219304 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r219304 | dvossel | 2009-09-17 16:59:21 -0500 (Thu, 17 Sep 2009) | 27
lines
  
  Merged revisions 219303 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r219303 | dvossel | 2009-09-17 16:29:37 -0500 (Thu, 17 Sep 2009) | 21
lines
    
    INVITE w/Replaces deadlock fix
    
    This patch cleans up the locking logic in chan_sip.c's
    handle_invite_replaces() function as well as making use
    of ast_do_masquerade() rather than forcing the masquerade
    on an ast_read().  The code had several redundant unlocks
    that would result in 'freed more times than we've locked!'
    errors. I cleaned these up as well as moving all the unlock
    logic to the end of the function.  This patch should also
    resolve the issue people were having with the replacecall
    channel never being unlocked with one legged calls.
    
    (closes issue https://issues.asterisk.org/view.php?id=15151)
    Reported by: irroot
    Patches:
          invite_w_replaces_1.4.diff uploaded by dvossel (license 671)
    Tested by: irroot, dvossel
    
    Review: https://reviewboard.asterisk.org/r/371/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=219307 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-17 17:07 svnbot         Checkin                                      
2009-09-17 17:07 svnbot         Note Added: 0110908                          
======================================================================