[asterisk-bugs] [DAHDI-linux 0015877]: [patch] FreeBSD port

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15877 
====================================================================== 
Reported By:                Max Khon
Assigned To:                
====================================================================== 
Project:                    DAHDI-linux
Issue ID:                   15877
Category:                   dahdi (the module)
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     acknowledged
====================================================================== 
Date Submitted:             2009-09-10 16:53 CDT
Last Modified:              2009-09-17 10:40 CDT
====================================================================== 
Summary:                    [patch] FreeBSD port
Description: 
zaptel-bsd was maintained in a separate SVN repository and syncing with
main zaptel tree always was a pain.

I would like to submit dahdi FreeBSD port back to Digium for inclusion
into main SVN tree, if possible.
====================================================================== 

---------------------------------------------------------------------- 
 (0110871) vadim (reporter) - 2009-09-17 10:40
 https://issues.asterisk.org/view.php?id=15877#c110871 
---------------------------------------------------------------------- 
--- drivers/dahdi/dahdi-base.c	(revision 7146)
+++ drivers/dahdi/dahdi-base.c	(working copy)
@@ -4270,6 +4270,10 @@
 			return -EFAULT;
 		return dahdi_set_default_zone(j);
 	case DAHDI_LOADZONE:
+		if (copy_from_user(&data, (void *) data, sizeof(data)))
+			return -EFAULT;
+		/* FALLTHRU */
+	case DAHDI_LOADZONE_V1:
 		return ioctl_load_zone(data);
 	case DAHDI_FREEZONE:
 		get_user(j, (int *) data);

This call to copy_form_user appears to contain ENORMOUS bug....
'data' contains user-mode address  the call should be something like:

		if (copy_from_user(&kernel_data_copy, (void *) data,
sizeof(kernel_data_copy))) 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-17 10:40 vadim          Note Added: 0110871                          
======================================================================