[asterisk-bugs] [Asterisk 0015905]: TCP/TLS invites(and possibly others) broken from r218504 and onward

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15905 
====================================================================== 
Reported By:                ebroad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15905
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-15 20:40 CDT
Last Modified:              2009-09-16 09:37 CDT
====================================================================== 
Summary:                    TCP/TLS invites(and possibly others) broken from
r218504 and onward
Description: 
Summary says it all.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015826 TCP calls no longer bridge (last workin...
====================================================================== 

---------------------------------------------------------------------- 
 (0110788) kpfleming (administrator) - 2009-09-16 09:37
 https://issues.asterisk.org/view.php?id=15905#c110788 
---------------------------------------------------------------------- 
Your anaylsis is in fact flawed; ast_append_str takes a format string and
arguments, and feeds the data read by fread() in as a string argument to a
format string with a single "%s" specifier. This means that the string
argument must be a valid C-style string, which means it must end with a
null character. ast_append_str will not copy this null character, it will
act like every other C library string function and treat that null
character as the end of the string.

As clearly requested in the bug posting guidelines, bug reports against
chan_sip's handling of protocol issues must include a log capture showing
the incoming packet data and chan_sip's handling of that data, otherwise we
can't do anything to analyze the problem. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-16 09:37 kpfleming      Note Added: 0110788                          
======================================================================