[asterisk-bugs] [Asterisk 0015854]: [patch] with 'transport=tls' and host not dynamic, port defaults to 5060 rather than 5061.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15854 
====================================================================== 
Reported By:                dvossel
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15854
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   minor
Priority:                   low
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 217077 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-08 11:53 CDT
Last Modified:              2009-09-15 14:26 CDT
====================================================================== 
Summary:                    [patch] with 'transport=tls' and host not dynamic,
port defaults to 5060 rather than 5061.
Description: 
[tls_peer]
context=default
type=peer
host=blah
transport=tls

Outgoing connections using this peer will default to port 5060 even though
tls uses 5061 by default.  A work around for this is to explicitly set
port=5061, but this should not be required.
====================================================================== 

---------------------------------------------------------------------- 
 (0110733) ebroad (reporter) - 2009-09-15 14:26
 https://issues.asterisk.org/view.php?id=15854#c110733 
---------------------------------------------------------------------- 
"I believe !portnum will only return true if portnum is 0, I don't think it
matters if portnum is negative or not if it is set to anything other than
0."

You are correct.

"The ast_sip_ouraddrfor sets p->sa.sin_addr.sin_port not p->socket.port as
the lines above it do. p->socket.port is used for our contact port, if that
isn't set right I guess they try to contact us on the wrong port."

Correct me if I am wrong, ast_sip_ouraddrfor() sets us, which
transmit_resgister() passes p->ourip. build_contact() uses
p->ourip.sin_port(see line 10683). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-15 14:26 ebroad         Note Added: 0110733                          
======================================================================