[asterisk-bugs] [Asterisk 0015854]: [patch] with 'transport=tls' and host not dynamic, port defaults to 5060 rather than 5061.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15854 
====================================================================== 
Reported By:                dvossel
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15854
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   minor
Priority:                   low
Status:                     assigned
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 217077 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-08 11:53 CDT
Last Modified:              2009-09-15 12:41 CDT
====================================================================== 
Summary:                    [patch] with 'transport=tls' and host not dynamic,
port defaults to 5060 rather than 5061.
Description: 
[tls_peer]
context=default
type=peer
host=blah
transport=tls

Outgoing connections using this peer will default to port 5060 even though
tls uses 5061 by default.  A work around for this is to explicitly set
port=5061, but this should not be required.
====================================================================== 

---------------------------------------------------------------------- 
 (0110706) dvossel (administrator) - 2009-09-15 12:41
 https://issues.asterisk.org/view.php?id=15854#c110706 
---------------------------------------------------------------------- 
"Found the register problem, chan_sip.c line 7612:
"<snip>
  if (portnum < 0) {
    portnum = STANDARD_TLS_PORT;
  }
</snip>

should be

if (!portnum) {
  portnum = STANDARD_TLS_PORT;
} "

Perhaps it should be (portnum <= 0) since the block above this could
possibly set portnum = -1.

I found this as well.

line 11866

...
if (r->transport == SIP_TRANSPORT_TLS || r->transport ==
SIP_TRANSPORT_TCP) {
    p->socket.port = sip_tcp_desc.local_address.sin_port;
}
...

perhaps if transport == TLS port should equal
sip_tls_desc.local_address.sin_port 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-15 12:41 dvossel        Note Added: 0110706                          
======================================================================