[asterisk-bugs] [Asterisk 0015895]: When useragent was added to realtime_update_peer in chan_sip the necessary ldap changes were not made

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15895 
====================================================================== 
Reported By:                jcovert
Assigned To:                suretec
====================================================================== 
Project:                    Asterisk
Issue ID:                   15895
Category:                   Resources/res_config_ldap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1.6 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-14 18:39 CDT
Last Modified:              2009-09-14 23:00 CDT
====================================================================== 
Summary:                    When useragent was added to realtime_update_peer in
chan_sip the necessary ldap changes were not made
Description: 
When useragent was added to realtime_update_peer in chan_sip the necessary
ldap changes were not made

The call to realtime_update_peer was modified in chan_sip to store
'useragent' This causes constant error messages:

  [Sep 14 14:34:27] ERROR[30323]: res_config_ldap.c:1286 update_ldap:
Couldn't modify dn:uid=johncovert.test,ou=people,dc=onstate,dc=net because
Undefined attribute type

This problem last happened when "lastms" was added.  See issue
https://issues.asterisk.org/view.php?id=15156.

Whenever a new item is added to realtime, it is necessary to update the
ldap definitions to support it. I propose making the following changes
required to eliminate this error:

1. Modify contrib/scripts/asterisk.ldap-schema as follows:

a. update version number and list this bug number in the changes.
b. Add objectIdentifier AstAccountUserAgent AstAttrType:59
c. Add
  attributetype ( AstAccountUserAgent
    NAME 'AstAccountUserAgent'
    DESC 'Ast Account User Agent'
    EQUALITY caseIgnoreMatch
    SUBSTR caseIgnoreSubstringsMatch
    SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)
d. Add AstAccountUserAgent to objectclass AsteriskSIPUser and for
completeness to objectclass AsteriskIAXUser even though not yet used.

2. Modify configs/res_ldap.conf.sample to include
     useragent = AstAccountUserAgent
  in the Sip Users Table

3. This time also modify chan_sip.c to refer future developers to the need
to update these two files whenever adding new realtime updates.

I expect to submit patches within the next two or three days once I have
actually tested this; I cannot do this while production is running today.

Regards/john
====================================================================== 

---------------------------------------------------------------------- 
 (0110647) jcovert (reporter) - 2009-09-14 23:00
 https://issues.asterisk.org/view.php?id=15895#c110647 
---------------------------------------------------------------------- 
Here's the deal.  On de-registration, useragent is updated to null.  That
should make the field go away.

In res/res_config_ldap.c the current code sets the mod_values field to a
pointer to a null string.  The LDAP interface requires a null pointer.  I
have a patch that fixes this, but I need to be sure that I make the section
of the code which allows a parameter to be specified MULTIPLE times (and
produces a semicolon separated list) works properly, i.e. ignores "null"
additions to the list and only deletes the entry if the ONLY time the
parameter is specified is null.

It's late.  That will be cleaned up tomorrow or Wednesday.

I'm also submitting a patch to chan_sip.c to add the following comment at
the call to realtime_update_peer (only the "principal" call):

IMPORTANT: Anytime you add a new parameter to be updated, you must also
add it to contrib/scripts/asterisk.ldap-schema and to
configs/res_ldap.conf.sample as described in bugs 15156 and 15895 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-14 23:00 jcovert        Note Added: 0110647                          
======================================================================