[asterisk-bugs] [Asterisk 0015100]: [patch] Directed pickup : picker picks own channel instead of called party's channel

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15100 
====================================================================== 
Reported By:                lmsteffan
Assigned To:                mnicholson
====================================================================== 
Project:                    Asterisk
Issue ID:                   15100
Category:                   Applications/app_directed_pickup
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.4.x Pending Blocker
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 194424 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-13 16:09 CDT
Last Modified:              2009-09-14 09:58 CDT
====================================================================== 
Summary:                    [patch] Directed pickup : picker picks own channel
instead of called party's channel
Description: 
When trying to pickup an extension, Asterisk does not identify the correct
channel. The error messages are (picker being 53, called party 52) :

chan_sip.c: Trying to pick up 52 at default
channel.c: Can't masquerade channel 'SIP/53-0a273e48' into itself!
app_directed_pickup.c: Unable to masquerade 'SIP/53-0a273e48' into
'SIP/53-0a273e48'app_directed_pickup.c: No target channel found for 52

It appears that the function pickup_by_exten does not check that the
channel it has found is not its own. The included patch seems to correct
that behaviour.
====================================================================== 

---------------------------------------------------------------------- 
 (0110598) svnbot (reporter) - 2009-09-14 09:58
 https://issues.asterisk.org/view.php?id=15100#c110598 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 218224

_U  trunk/
U   trunk/apps/app_directed_pickup.c

------------------------------------------------------------------------
r218224 | mnicholson | 2009-09-14 09:58:55 -0500 (Mon, 14 Sep 2009) | 14
lines

Merged revisions 218223 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r218223 | mnicholson | 2009-09-14 09:53:57 -0500 (Mon, 14 Sep 2009) | 8
lines
  
  Ensure we don't pickup ourselves when doing pickup by exten.
  
  (closes issue https://issues.asterisk.org/view.php?id=15100)
  Reported by: lmsteffan
  Patches:
        (modified) pickup.patch uploaded by lmsteffan (license 779)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=218224 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-14 09:58 svnbot         Checkin                                      
2009-09-14 09:58 svnbot         Note Added: 0110598                          
======================================================================