[asterisk-bugs] [Asterisk 0015879]: [patch] voicemail should mark messages as read by doing an UPDATE instead of an INSERT followed by a DELETE

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15879 
====================================================================== 
Reported By:                KyleK
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15879
Category:                   Applications/app_voicemail/ODBC
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.6 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.1 
SVN Revision (number only!): 218049 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-10 21:54 CDT
Last Modified:              2009-09-13 18:49 CDT
====================================================================== 
Summary:                    [patch] voicemail should mark messages as read by
doing an UPDATE instead of an INSERT followed by a DELETE
Description: 
I sniffed out that app_voicemail was doing an INSERT to move a message from
Inbox to Old and decided to change it to an UPDATE. I'm running asterisk
1.6.1 svn but I'll try this against trunk in a bit.
====================================================================== 

---------------------------------------------------------------------- 
 (0110585) tilghman (administrator) - 2009-09-13 18:49
 https://issues.asterisk.org/view.php?id=15879#c110585 
---------------------------------------------------------------------- 
There's a few changes that you'll need to make for this patch to be
acceptable.  All are outlined in doc/CODING-GUIDELINES.

1) Tab-indentation, not spaces.
2) No C++-style comments.
3) Spaces after commas in function calls, not before.

Also, you may want to make sure that if somebody records a voicemail at
the same time as you are listening to voicemail, that this does not create
a race whereby the new message is stuck into the slot you just renamed
from, and the forthcoming delete in the code (which is supposed to be a
no-op) kills the new message. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-13 18:49 tilghman       Note Added: 0110585                          
======================================================================