[asterisk-bugs] [Asterisk 0015847]: NOTIFY to contains double sip:

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15847 
====================================================================== 
Reported By:                ebroad
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15847
Category:                   Channels/chan_sip/Subscriptions
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 216956 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-08 02:19 CDT
Last Modified:              2009-09-08 02:26 CDT
====================================================================== 
Summary:                    NOTIFY to contains double sip:
Description: 
The To header contains an extra sip:
====================================================================== 

---------------------------------------------------------------------- 
 (0110299) ebroad (reporter) - 2009-09-08 02:26
 https://issues.asterisk.org/view.php?id=15847#c110299 
---------------------------------------------------------------------- 
I'm not sure when this crept in, however, the issue and resolution are
quite simple. On line 10822 in chan_sip.c, we have 'if !strncasecmp(uri,
"sip:", 4) then append sip: else append nothing', the problem is that
strncasecmp() returns 0 when it finds a match, so !0 evaluates to true,
appending sip: when we already have one. Removing the ! operator resolves
the issue. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-08 02:26 ebroad         Note Added: 0110299                          
======================================================================