[asterisk-bugs] [Asterisk 0015752]: [patch] Thread debugging version of DEADLOCK_AVOIDANCE: wrong line number if re-lock fails.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15752 
====================================================================== 
Reported By:                davidw
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15752
Category:                   Core/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           Older 1.6.1 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-08-20 13:33 CDT
Last Modified:              2009-09-07 12:19 CDT
====================================================================== 
Summary:                    [patch] Thread debugging version of
DEADLOCK_AVOIDANCE: wrong line number if re-lock fails.
Description: 
As described in https://issues.asterisk.org/view.php?id=15314, if the mutex
referenced by DEADLOCK_AVOIDANCE goes
away, the "Error obtaining mutex: Invalid argument" error message reports
the line number where the lock was originally obtained, not that of the
failure.

This is because DEADLOCK_AVOIDANCE takes special steps to retain the
original line number.  I believe the intent of this is for accurate tracing
of deadlock origins, but I believe that it should be reporting the actual
line number if the actual re-lock call fails.
====================================================================== 

---------------------------------------------------------------------- 
 (0110292) davidw (reporter) - 2009-09-07 12:19
 https://issues.asterisk.org/view.php?id=15752#c110292 
---------------------------------------------------------------------- 
Failed to build on 1.6.1.0.  (Applied at offset -7.)

   [CC] astobj2.c -> astobj2.o
astobj2.c: In function '_ao2_lock':
astobj2.c:160: warning: passing argument 5 of '__ast_pthread_mutex_lock'
makes integer from pointer without a cast
astobj2.c:160: error: too few arguments to function
'__ast_pthread_mutex_lock'
astobj2.c:162: warning: control reaches end of non-void function
astobj2.c: In function '_ao2_trylock':
astobj2.c:200: warning: passing argument 5 of
'__ast_pthread_mutex_trylock' makes integer from pointer without a cast
astobj2.c:200: error: too few arguments to function
'__ast_pthread_mutex_trylock'
make[1]: *** [astobj2.o] Error 1
make: *** [utils] Error 2 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-07 12:19 davidw         Note Added: 0110292                          
======================================================================