[asterisk-bugs] [Asterisk 0015819]: [patch] buggy output in "sip show channelstats"

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15819 
====================================================================== 
Reported By:                klaus3000
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   15819
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           1.6.2.0-beta4 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-09-02 12:09 CDT
Last Modified:              2009-09-07 04:30 CDT
====================================================================== 
Summary:                    [patch] buggy output in "sip show channelstats"
Description: 
Hi!

"sip show channelstats" output is wrong
- the packetloss in % is always 0 due to integer division instead of float
divison
- the local measured jitter is reported in as rxjitter (which in in
seconds) * 100, converted to int. Multiply with 100 makes no sense - I
supsect a type and it should be 1000 as all other jittervalues (max/min...)
are also multiplyed with 1000.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015807 rtt should be stored as double in struc...
====================================================================== 

---------------------------------------------------------------------- 
 (0110270) klaus3000 (reporter) - 2009-09-07 04:30
 https://issues.asterisk.org/view.php?id=15819#c110270 
---------------------------------------------------------------------- 
I changed the outputformat to:
gucci*CLI> sip show channelstats
Peer             Call ID      Duration Recv: Pack  Lost       (     %)
Jitter Send: Pack  Lost       (     %) Jitter
88.198.53.113    1eac1e7d-dc  00:00:01 0000000072  0000000000 ( 0.00%)
000000 0000000071  0000000000 ( 0.00%) 000000

So, packetloss in % is now decimal, calculated correctly, and checked
against divsion-by-zero, and rtp/rtcp structure is initialized with
memset(0) to have all variables set to 0.

The jitter is still wrong, but the bug is not in chan_sip and will be a
separate patch.

@oej:
> Updated 1.4 branch too. 

Why/how? I could not find channelstats this in 1.4 branch.


I added patches for 1.4-trunk. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-07 04:30 klaus3000      Note Added: 0110270                          
======================================================================