[asterisk-bugs] [Asterisk 0015123]: out of bounds crash and core dump

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15123 
====================================================================== 
Reported By:                axisinternet
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   15123
Category:                   Resources/res_musiconhold
Reproducibility:            N/A
Severity:                   crash
Priority:                   normal
Status:                     ready for testing
Asterisk Version:           1.4.22 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-15 16:02 CDT
Last Modified:              2009-09-01 15:39 CDT
====================================================================== 
Summary:                    out of bounds crash and core dump
Description: 
Crash and core dump - will attach backtrace from the core dump. 
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0015195 double free or corruption (!prev) in mo...
related to          0015109 [patch] Abort by memory allocator, poss...
====================================================================== 

---------------------------------------------------------------------- 
 (0109914) svnbot (reporter) - 2009-09-01 15:39
 https://issues.asterisk.org/view.php?id=15123#c109914 
---------------------------------------------------------------------- 
Repository: asterisk-addons
Revision: 1023

U   branches/1.4/formats/format_mp3.c

------------------------------------------------------------------------
r1023 | russell | 2009-09-01 15:38:54 -0500 (Tue, 01 Sep 2009) | 45 lines

Fix memory corruption caused by format_mp3.

format_mp3 claimed that it provided AST_FRIENDLY_OFFSET in frames returned
by
read().  However, it lied.  This means that other parts of the code that
attempted to make use of the offset buffer would end up corrupting the
fields
in the ast_filestream structure.  This resulted in quite a few crashes due
to
unexpected values for fields in ast_filestream.

This patch closes out quite a few bugs.  However, some of these bugs have
been
open for a while and have been an area where more than one bug has been
discussed.  So with that said, anyone that is following one of the issues
closed here, if you still have a problem, please open a new bug report for
the
specific problem you are still having.  If you do, please ensure that the
bug
report is based on the newest version of Asterisk, and that this patch is
applied if format_mp3 is in use.  Thanks!

(closes issue https://issues.asterisk.org/view.php?id=15109)
Reported by: jvandal
Tested by: aragon, russell, zerohalo, marhbere, rgj

(closes issue https://issues.asterisk.org/view.php?id=14958)
Reported by: aragon

(closes issue https://issues.asterisk.org/view.php?id=15123)
Reported by: axisinternet

(closes issue https://issues.asterisk.org/view.php?id=15041)
Reported by: maxnuv

(closes issue https://issues.asterisk.org/view.php?id=15396)
Reported by: aragon

(closes issue https://issues.asterisk.org/view.php?id=15195)
Reported by: amorsen
Tested by: amorsen

(closes issue https://issues.asterisk.org/view.php?id=15781)
Reported by: jensvb

(closes issue https://issues.asterisk.org/view.php?id=15735)
Reported by: thom4fun

(closes issue https://issues.asterisk.org/view.php?id=15460)
Reported by: marhbere

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk-addons?view=rev&revision=1023 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-09-01 15:39 svnbot         Checkin                                      
2009-09-01 15:39 svnbot         Note Added: 0109914                          
======================================================================