[asterisk-bugs] [Asterisk 0015495]: [patch] Asterisk runs over end of buffer reading manager input over HTTP and segfaults

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15495 
====================================================================== 
Reported By:                pdf
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15495
Category:                   Core/HTTP
Reproducibility:            sometimes
Severity:                   crash
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 206284 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-07-13 23:11 CDT
Last Modified:              2009-10-27 15:28 CDT
====================================================================== 
Summary:                    [patch] Asterisk runs over end of buffer reading
manager input over HTTP and segfaults
Description: 
We have a number of applications working over manager, and whilst I have
not been able to nail down what precisely is causing this, it has occurred
a number of times.  It looks like xml_translate is looking for a
null-terminated string, but the string is not always null-terminated, so it
runs off the end of the buffer and segfaults.
====================================================================== 

---------------------------------------------------------------------- 
 (0112833) svnbot (reporter) - 2009-10-27 15:28
 https://issues.asterisk.org/view.php?id=15495#c112833 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 226170

_U  branches/1.6.2/
U   branches/1.6.2/main/manager.c

------------------------------------------------------------------------
r226170 | tilghman | 2009-10-27 15:28:59 -0500 (Tue, 27 Oct 2009) | 21
lines

Merged revisions 226159 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r226159 | tilghman | 2009-10-27 15:22:07 -0500 (Tue, 27 Oct 2009) | 14
lines
  
  Merged revisions 226138 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r226138 | tilghman | 2009-10-27 15:16:49 -0500 (Tue, 27 Oct 2009) | 7
lines
    
    Manager output is not always NULL-terminated, so force a NULL at the
end of the filestream.
    (closes issue https://issues.asterisk.org/view.php?id=15495)
     Reported by: pdf
     Patches: 
           20090916__issue15495.diff.txt uploaded by tilghman (license 14)
     Tested by: pdf
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=226170 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-27 15:28 svnbot         Checkin                                      
2009-10-27 15:28 svnbot         Note Added: 0112833                          
======================================================================