[asterisk-bugs] [Asterisk 0015940]: [patch] IAX does not allow CALLERID(num) contain non-numbers.

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15940 
====================================================================== 
Reported By:                dimas
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15940
Category:                   Channels/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-225 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-09-22 19:40 CDT
Last Modified:              2009-10-21 17:10 CDT
====================================================================== 
Summary:                    [patch] IAX does not allow CALLERID(num) contain
non-numbers.
Description: 
( I already explained the issue here:
http://lists.digium.com/pipermail/asterisk-dev/2009-August/039257.html )

The thing is that IAX channel driver "shrinks" (ast_shrink_phone_number)
caller number. Which was probably the good thing before. However nowadays
when you have Skype support integrated, skype names passed via
CALLERID(num) get damaged.

I believe that only drivers which know they can not pass arbitrary number
(like DAHDI for example) should do shrinking of number before sending out.
While inside Asterisk (or relayed to another Asterisk with SIP/IAX) we
should presever original number.

Obviously I can create a patch for chan_iax which removes the shrinking
because this patch is trivial. However issue may be more global and affect
other drivers so I believe it is better to hear from Digium guys first -
maybe they have another opinion about how to solve that issue or do not
consider it an issue at all :)
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0006450 [patch] Characters are removed from cal...
====================================================================== 

---------------------------------------------------------------------- 
 (0112591) svnbot (reporter) - 2009-10-21 17:10
 https://issues.asterisk.org/view.php?id=15940#c112591 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 225310

_U  branches/1.6.0/
U   branches/1.6.0/channels/chan_iax2.c
U   branches/1.6.0/channels/chan_sip.c
U   branches/1.6.0/configs/iax.conf.sample
U   branches/1.6.0/configs/sip.conf.sample

------------------------------------------------------------------------
r225310 | dvossel | 2009-10-21 17:10:10 -0500 (Wed, 21 Oct 2009) | 34
lines

Merged revisions 225033 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r225033 | dvossel | 2009-10-21 09:39:10 -0500 (Wed, 21 Oct 2009) | 27
lines
  
  Merged revisions 225032 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r225032 | dvossel | 2009-10-21 09:37:04 -0500 (Wed, 21 Oct 2009) | 20
lines
    
    IAX/SIP shrinkcallerid option
    
    The shrinking of caller id removes '(', ' ', ')', non-trailing '.',
    and '-' from the string.  This means values such as 555.5555 and
    test-test result in 555555 and testtest.  There are instances,
    such as Skype integration, where a specific value is passed via
    caller id that must be preserved unmodified.  This patch makes
    the shrinking of caller id optional in chan_sip and chan_iax in
    order to support such cases.  By default this option is on to
    preserve previous expected behavior.
    
    (closes issue https://issues.asterisk.org/view.php?id=15940)
    Reported by: dimas
    Patches:
          v2-15940.patch uploaded by dimas (license 88)
          15940_shrinkcallerid_trunk.c uploaded by dvossel (license 671)
    Tested by: dvossel
    
    Review: https://reviewboard.asterisk.org/r/408/
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=225310 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-21 17:10 svnbot         Checkin                                      
2009-10-21 17:10 svnbot         Note Added: 0112591                          
======================================================================