[asterisk-bugs] [Asterisk 0016103]: Sometimes macro in h extension returns to s extension

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16103 
====================================================================== 
Reported By:                majorbloodnok
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   16103
Category:                   Applications/app_macro
Reproducibility:            sometimes
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           Older 1.4 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-20 09:14 CDT
Last Modified:              2009-10-21 10:56 CDT
====================================================================== 
Summary:                    Sometimes macro in h extension returns to s
extension
Description: 
[Incidentally the bug guidelines link on the report and entry pages is a
dead link]

Example code:

exten => s,1,Dial(....)
exten => s,2,Noop(macro returns here incorrectly)

exten => h,1,Macro(some-macro)
exten => h,2,Noop(macro shoul return here but does not)

I am unable to reproduce this consistently. Analysis is in Adduitional
Information. Version is 1.4.22 but I see (what I think) may be the error is
still in subversion trunk

====================================================================== 

---------------------------------------------------------------------- 
 (0112545) majorbloodnok (reporter) - 2009-10-21 10:56
 https://issues.asterisk.org/view.php?id=16103#c112545 
---------------------------------------------------------------------- 
My colleague Roman Murar has analysed and made a fix - the diff is:

2540,2547c2540,2541
<
<     if (res != AST_PBX_KEEPALIVE) {
<
<         if(c->hangupcause == 0) {
<             ast_softhangup(c, AST_SOFTHANGUP_DEV);
<         }
<     }
<
---
>     if (res != AST_PBX_KEEPALIVE)
>         ast_softhangup(c, c->hangupcause ? c->hangupcause :
AST_CAUSE_NORMAL_CLEARING); 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-21 10:56 majorbloodnok  Note Added: 0112545                          
======================================================================