[asterisk-bugs] [Asterisk 0015285]: [patch] reworked chan_ooh323

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15285 
====================================================================== 
Reported By:                may213
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15285
Category:                   Addons/chan_ooh323
Reproducibility:            random
Severity:                   feature
Priority:                   normal
Status:                     confirmed
Target Version:             1.6.x Version Tracker
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-06-07 18:51 CDT
Last Modified:              2009-10-15 08:39 CDT
====================================================================== 
Summary:                    [patch] reworked chan_ooh323
Description: 
There is patch to asterisk-addons-1.6.1.0 for reworked version of 
chan_ooh323 channel module.

main subject of changes is performance and scalability improvement.
one processing thread is replaced with many threads (one for cmdChannel
of EndPoint, one for incoming call creation, one for call processing).

chan_ooh323 with this reworking is more stable and have good performance
in compare with chan_h323.
chan_h323 have memory leaks in all my asterisk systems (which have
versions from 1.2 up to 1.6.1) and grow more than 2Gb virtual memory after
proccessing about 200000 calls. After many years of solving this trouble i
cancel this work and begin work on chan_ooh323.

asterisk 1.6.1 with this version of chan_ooh323 have uptime 4 days and
proccess about 400 000 calls and have 98Mb virtual memory with 4 active
channels and no memory leak detected by asterisk malloc debug system.
(all modules include OOH323 stack code are compiled with MALLOC_DEBUG
options)
Before testing 1.6.1 i work with 1.4 version and had 8 days uptime
asterisk with more than 1000000 calls processed without leaks.

Also there is small changes for new options - incoming call limit, 
numbering of calls, t35country code and vendor/version identification
(albania code is not liked for me ;))

More detail list of changes/improvements is in Changes-ooh323.eng.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015046 [patch] Data truncated in ooh323_reques...
====================================================================== 

---------------------------------------------------------------------- 
 (0112322) c0w (reporter) - 2009-10-15 08:39
 https://issues.asterisk.org/view.php?id=15285#c112322 
---------------------------------------------------------------------- 
May the trunk version does not build correctly.

   [CC] chan_ooh323.c -> chan_ooh323.o
In file included from chan_ooh323.h:54,
                 from chan_ooh323.c:18:
/usr/src/test/asterisk/include/asterisk/rtp_engine.h:100: error: nested
redefinition of ‘enum ast_rtp_options’
/usr/src/test/asterisk/include/asterisk/rtp_engine.h:100: error:
redeclaration of ‘enum ast_rtp_options’
/usr/src/test/asterisk/include/asterisk/rtp_engine.h:102: error:
redeclaration of enumerator ‘AST_RTP_OPT_G726_NONSTANDARD’
/usr/include/asterisk/rtp.h:60: error: previous definition of
‘AST_RTP_OPT_G726_NONSTANDARD’ was here
chan_ooh323.c:21:1: warning: "HAVE_SPANDSP_EXPOSE_H" redefined
In file included from /usr/src/test/asterisk/include/asterisk.h:21,
                 from chan_ooh323.h:19,
                 from chan_ooh323.c:18:
/usr/src/test/asterisk/include/asterisk/autoconfig.h:865:1: warning: this
is the location of the previous definition
chan_ooh323.c:80: warning: function declaration isn’t a prototype
chan_ooh323.c:714: warning: no previous prototype for
‘find_friend’
chan_ooh323.c: In function ‘ooh323_digit_begin’:
chan_ooh323.c:805: warning: implicit declaration of function
‘ooRequestChangeMode’
chan_ooh323.c: In function ‘ooh323_call’:
chan_ooh323.c:922: warning: implicit declaration of function
‘isRunning’
chan_ooh323.c:924: warning: implicit declaration of function
‘ooRunCall’
chan_ooh323.c: In function ‘onOutgoingCall’:
chan_ooh323.c:1781: warning: format ‘%lx’ expects type
‘long unsigned int’, but argument 5 has type ‘struct
OOH323CallData *’
chan_ooh323.c:1817: warning: implicit declaration of function
‘ooIsDailedDigit’
chan_ooh323.c: In function ‘onNewCallCreated’:
chan_ooh323.c:1844: warning: format ‘%lx’ expects type
‘long unsigned int’, but argument 5 has type ‘struct
OOH323CallData *’
chan_ooh323.c:1847: warning: implicit declaration of function
‘ooh323c_start_call_thread’
chan_ooh323.c: In function ‘onCallCleared’:
chan_ooh323.c:2014: warning: implicit declaration of function
‘ooh323c_stop_call_thread’
chan_ooh323.c: In function ‘reload’:
chan_ooh323.c:2373: warning: implicit declaration of function
‘ooh323_reload’
chan_ooh323.c: In function ‘reload_config’:
chan_ooh323.c:2472: warning: implicit declaration of function
‘ooH323EpEnableMediaWaitForConnect’
chan_ooh323.c: In function ‘load_module’:
chan_ooh323.c:3119: warning: initialization from incompatible pointer
type
chan_ooh323.c: At top level:
chan_ooh323.c:3925: warning: no previous prototype for
‘setup_udptl_connection’
chan_ooh323.c:3985: warning: no previous prototype for
‘close_udptl_connection’
chan_ooh323.c: In function ‘onModeChanged’:
chan_ooh323.c:4274: warning: passing argument 2 of
‘t38_gateway_init’ from incompatible pointer type
chan_ooh323.c:4223: warning: unused variable ‘f’
make[1]: *** [chan_ooh323.o] Error 1
make: *** [addons] Error 2

thanks 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-15 08:39 c0w            Note Added: 0112322                          
======================================================================