[asterisk-bugs] [Asterisk 0015684]: [patch] different 'ringt' timeout counting styles througout chan_dahdi/sig_analog code

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15684 
====================================================================== 
Reported By:                alecdavis
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   15684
Category:                   Channels/chan_dahdi
Reproducibility:            N/A
Severity:                   text
Priority:                   normal
Status:                     resolved
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!): 211232 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-08-09 05:29 CDT
Last Modified:              2009-10-07 15:11 CDT
====================================================================== 
Summary:                    [patch] different 'ringt' timeout counting styles
througout chan_dahdi/sig_analog code
Description: 
Below are the three styles I've found.
All trying to achive very close to the same thing, to timeout 'ringt'.
<pre>
<u>Style 1:</u>
if (analog_p->ringt) {
    analog_p->ringt--;
}
if (analog_p->ringt == 1) {
    return -1;
}

<u>Style 2:</u>
if (p->ringt)
   p->ringt--;
   if (p->ringt == 1) {
       res = -1;
       break;
   }
}

<u>Style 3:</u>
if (p->ringt == 1) {
    ast_mutex_unlock(&p->lock);
    return NULL;
}
else if (p->ringt > 0)
    p->ringt--;
</pre>

====================================================================== 

---------------------------------------------------------------------- 
 (0112022) svnbot (reporter) - 2009-10-07 15:11
 https://issues.asterisk.org/view.php?id=15684#c112022 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 222652

U   trunk/channels/chan_dahdi.c

------------------------------------------------------------------------
r222652 | jpeeler | 2009-10-07 15:11:33 -0500 (Wed, 07 Oct 2009) | 8 lines

Change ringt (ring timeout) styles to be consistent across chan_dahdi.

(closes issue https://issues.asterisk.org/view.php?id=15684)
Reported by: alecdavis
Patches: 
      chan_dahdi.bug15684.diff2.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=222652 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-07 15:11 svnbot         Note Added: 0112022                          
2009-10-07 15:11 svnbot         Status                   ready for review =>
assigned
2009-10-07 15:11 svnbot         Assigned To               => jpeeler         
2009-10-07 15:11 svnbot         Status                   assigned => resolved
2009-10-07 15:11 svnbot         Resolution               open => fixed       
======================================================================