[asterisk-bugs] [Asterisk 0015894]: SIP register via tls causes lock on sip reload

[Asterisk Bug Tracker]

The following issue is now READY FOR REVIEW. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15894 
====================================================================== 
Reported By:                dvossel
Assigned To:                dvossel
====================================================================== 
Project:                    Asterisk
Issue ID:                   15894
Category:                   Channels/chan_sip/TCP-TLS
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 218430 
Request Review:              
====================================================================== 
Date Submitted:             2009-09-14 17:47 CDT
Last Modified:              2009-10-07 14:01 CDT
====================================================================== 
Summary:                    SIP register via tls causes lock on sip reload
Description: 
I ran into this problem because of another issue Asterisk has with TLS.

register => tls://user:1234@mydomain

Given the register line above in sip.conf, I'd expect the register request
to be send via port 5061.  Instead it defaults to port 5060 which is
incorrect for TLS.

----------------------------------------------------------------
*CLI> sip show registry
Host                           dnsmgr Username       Refresh State        
       Reg.Time                 
mydomain:5060               N      user             120 Request Sent
----------------------------------------------------------------

Now here's the odd part.  I decided to go into my sip.conf and explicitly
set the register line to have a port, and when I issued a sip reload
everything locked up, even the CLI.  I was able to reproduce the steps and
got the same results everytime.

It seems that this is somehow caused by the receiving end binding to port
5061 and me sending the registration using port 5060.  If I bind the
receiving end to 5060 this works even though that is not the correct port
for tls.  I tried another test where I pointed the register at a fake
domain, but nothing locked up.




======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0015343 [patch] lock in sip_tcp_helper_thread
child of            0013136 [patch] sip peer qualified failed, aste...
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-07 14:01 dvossel        Status                   assigned => ready for
review
======================================================================