[asterisk-bugs] [Asterisk 0006450]: [patch] Characters are removed from caller ID numbers that are not phone numbers

[Asterisk Bug Tracker]

The following issue has been set as RELATED TO issue 0015940. 
====================================================================== 
https://issues.asterisk.org/view.php?id=6450 
====================================================================== 
Reported By:                jcomellas
Assigned To:                oej
====================================================================== 
Project:                    Asterisk
Issue ID:                   6450
Category:                   Channels/chan_sip/Interoperability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.2 
SVN Revision (number only!): 9327 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2006-02-09 15:03 CST
Last Modified:              2009-10-07 09:08 CDT
====================================================================== 
Summary:                    [patch] Characters are removed from caller ID
numbers that are not phone numbers
Description: 
When Asterisk receives a call from a party that is sending a SIP URI as its
caller ID number, it calls ast_shrink_phone_number() on it even if it's not
a phone number. For example, if the SIP message contains this "From"
header: 

From: "Juan Jose Comellas"
<sip:juan.comellas at novamens.com>;tag=as16ac88e2

Asterisk will set the caller ID name to "Juan Jose Comellas" and the
caller ID number to "juancomellas", which is obviously invalid. To solve
this problem I've added a new function in callerid.{h,c} called
ast_is_fancy_phonenumber() that checks whether the caller ID number is a
phone number (including characters normally used to display human-readable
phone numbers). I've also added a call to this function before trying to
shrink the phone number in all the places where this is done in
channels/chan_sip.c

This problem may affect other parts or channels in Asterisk, but I don't
have enough knowledge of them to change the other calls to
ast_shrink_phone_number(). 

Please let me know if I should do the same for the other calls to
ast_shrink_phone_number().

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0006723 When no, or improper CID number is spec...
related to          0015940 [patch] IAX does not allow CALLERID(num...
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-07 09:08 lmadsen        Relationship added       related to 0015940  
======================================================================