[asterisk-bugs] [Asterisk 0015924]: pulse and hardware dtmf digits not detected in chan_dahdi/trunk

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15924 
====================================================================== 
Reported By:                tzafrir
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   15924
Category:                   Channels/chan_dahdi
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 219719 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-09-21 10:17 CDT
Last Modified:              2009-10-05 14:24 CDT
====================================================================== 
Summary:                    pulse and hardware dtmf digits not detected in
chan_dahdi/trunk
Description: 
sig_analog (in the chan_dahdi rewrite) fails to detect pulse digits events
as well as DTMF up events sent from DAHDI.

The events 'pulse digit N', 'dtmf digit N down', and 'dtmf digit N up' are
marked by (N | 1<<16) , (N | 1<<17) and (N | 1<<18), respectively. See
dahdi/include/user.h .

However in chan_dahdi.c:my_get_event() , the raw event number is filtered
through dahdievent_to_analogevent() . Which does not find those events and
thus returns ANALOG_EVENT_ERROR . This has the unlucky value of 13. Sadly,
though, computers are over-rational and don't consider 13 as an error
value. And generally this functionality is missing.

Generally implementing pulse dialing should be simple. Supporting DTMF
down/up events involves muting the line.
====================================================================== 

---------------------------------------------------------------------- 
 (0111867) svnbot (reporter) - 2009-10-05 14:24
 https://issues.asterisk.org/view.php?id=15924#c111867 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 222109

_U  branches/1.6.2/

------------------------------------------------------------------------
r222109 | jpeeler | 2009-10-05 14:24:13 -0500 (Mon, 05 Oct 2009) | 17
lines

Blocked revisions 222108 via svnmerge

........
  r222108 | jpeeler | 2009-10-05 14:20:36 -0500 (Mon, 05 Oct 2009) | 12
lines
  
  Add a few missing events to analog_handle_event.
  
  The reported bug was actually only for pulsedigit, dtmfup, and dtmfdown
  handling. Also added recognition for fax events (just some verbose
output) and
  fixed handling for the ec_disabled_event. In order to make comparing the
analog
  version of events to the DAHDI events easier, the ordering has been
changed to
  follow that of the DAHDI events.
  
  (closes issue https://issues.asterisk.org/view.php?id=15924)
  Reported by: tzafrir
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=222109 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-05 14:24 svnbot         Checkin                                      
2009-10-05 14:24 svnbot         Note Added: 0111867                          
======================================================================