[asterisk-bugs] [LibPRI 0015604]: [patch] Support for called_party_subaddr, currently only calling_party_subaddr is supported

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15604 
====================================================================== 
Reported By:                alecdavis
Assigned To:                rmudgett
====================================================================== 
Project:                    LibPRI
Issue ID:                   15604
Category:                   NewFeature
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:           SVN 
JIRA:                        
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             2009-07-28 21:51 CDT
Last Modified:              2009-10-02 06:51 CDT
====================================================================== 
Summary:                    [patch] Support for called_party_subaddr, currently
only calling_party_subaddr is supported
Description: 
Looking at q931.c it only has dump_called_party_subaddr
it's missing receive_called_party_subaddr, transmit_called_party_subaddr,
and associated pri_call changes. Maybe more...

The Telecom Specs in NZ suggests that SUB ADDRESS is always on, so doing
"desk to desk" between offices each with an asterisk box over the ISDN
should then be possible, without a whole load of DDI numbers required.

Is there any work beinging done for this?


======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0001877 Useful enhancement to chan_zap would be...
====================================================================== 

---------------------------------------------------------------------- 
 (0111790) alecdavis (reporter) - 2009-10-02 06:51
 https://issues.asterisk.org/view.php?id=15604#c111790 
---------------------------------------------------------------------- 
Please remove libpri_subaddr_trunk.diff5.txt and
asterisk_subaddr_trunk.diff5.txt files

asterisk_subaddr_trunk.diff6.txt:
added pack_string_to_bcd for transmit of UserSpecified data, not NSAP.
  right padding, not left padding for odd length. 
completed pri_sr_set_called_subaddress.
func_connectedline and func_callerid now complete.

libpri_subaddr_trunk.diff6.txt:
receive and transmit calling/called subaddr now support the 
   type field, for UserDefined and NSAP.
   odd/even field for length of BCD

todo:
  unpack_bcd_to_string
  remove debug prints.

Hope I haven't mixed up connectedline and callerid use.

<u>dialplan code:</u>
exten => _86XX,n,Set(CALLERID(subaddr-type)=2)
exten => _86XX,n,Set(CALLERID(subaddr)=55555)
exten => _86XX,n,Set(CALLERID(subaddr-valid)=1)
exten => _86XX,n,Set(CALLERID(dnid-subaddr)=3579)
exten => _86XX,n,Set(CALLERID(dnid-subaddr-valid)=1)

<u>console output:</u>
> Protocol Discriminator: Q.931 (8)  len=40
> Call Ref: len= 2 (reference 2/0x2) (Originator)
> Message Type: SETUP (5)
> [04 03 80 90 a3]
> Bearer Capability (len= 5) [ Ext: 1  Q.931 Std: 0  Info transfer
capability: Speech (0)
>                              Ext: 1  Trans mode/rate: 64kbps,
circuit-mode (16)
>                                User information layer 1: A-Law (35)
> [18 03 a1 83 9f]
> Channel ID (len= 5) [ Ext: 1  IntID: Implicit  Other(PRI)  Spare: 0 
Preferred  Dchan: 0
>                        ChanSel: As indicated in following octets
>                       Ext: 1  Coding: 0  Number Specified  Channel Type:
3
>                       Ext: 1  Channel: 31 Type: CPE]
> [6c 02 00 80]
> Calling Number (len= 4) [ Ext: 0  TON: Unknown Number Type (0)  NPI:
Unknown Number Plan (0)
>                           Presentation: Presentation permitted, user
number not screened (0)  '' ]
> [6d 04 a8 55 55 05]
><b> Calling Sub-Address (len= 6) [ Ext: 1  Type: User Specified (2)  O: 1
 'UU' ]</b>
> [70 05 80 38 36 30 34]
> Called Number (len= 7) [ Ext: 1  TON: Unknown Number Type (0)  NPI:
Unknown Number Plan (0)  '8604' ]
> [71 05 80 33 35 37 39]
><b> Called Sub-Address (len= 7) [ Ext: 1  Type: NSAP (X.213/ISO 8348 AD2)
(0)  O: 0  '3579' ]</b> 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-02 06:51 alecdavis      Note Added: 0111790                          
======================================================================