[asterisk-bugs] [Asterisk 0015999]: Strange nasty sound (Because Asterisk tryes to handle new voicemail, but there is no voicemails, voicemail isn't used)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15999 
====================================================================== 
Reported By:                KrisV
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15999
Category:                   Channels/chan_dahdi
Reproducibility:            sometimes
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.5 
JIRA:                        
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-01 04:47 CDT
Last Modified:              2009-10-01 05:20 CDT
====================================================================== 
Summary:                    Strange nasty sound (Because Asterisk tryes to
handle new voicemail, but there is no voicemails, voicemail isn't used)
Description: 
chan_dahdi.c: 8369
  res = has_voicemail(last);
  if (last->msgstate != res) {
  /* This channel has a new voicemail state,					*  initiate a thread to
send an MWI message */
  ...
  }
But in comments for msgstate:
/*! \brief -1 = unknown, 0 = no messages, 1 = new messages available */
int msgstate;
So, if res=0 and last->msgstate = -1 there is a new message! But it's not
true.


So, more logical to fix like:
  res = has_voicemail(last);
  if (last->msgstate != res && res > 0) {
  /* This channel has a new voicemail state,					* initiate a thread to
send an MWI message */
  ...
  }
In this case the strange sound doesn't appear.


====================================================================== 

---------------------------------------------------------------------- 
 (0111695) davidw (reporter) - 2009-10-01 05:20
 https://issues.asterisk.org/view.php?id=15999#c111695 
---------------------------------------------------------------------- 
Digium cannot look at code unless it is submitted as an attachment, after
you have accepted their code submission licence terms, and they have agreed
your acceptance. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-10-01 05:20 davidw         Note Added: 0111695                          
======================================================================