[asterisk-bugs] [Asterisk 0016343]: [patch] New CLI command: manager show settings

Asterisk Bug Tracker noreply at bugs.digium.com
Sun Nov 29 22:55:54 CST 2009


A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16343 
====================================================================== 
Reported By:                pabelanger
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16343
Category:                   Core/ManagerInterface
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 231401 
Request Review:              
====================================================================== 
Date Submitted:             2009-11-28 17:34 CST
Last Modified:              2009-11-29 22:55 CST
====================================================================== 
Summary:                    [patch] New CLI command: manager show settings
Description: 
Since looking at source is the best way to find default settings for
values, it is not the easy way to find tho.  Following 'sip show settings',
I've added logic to the manager.  

It also helps to see what values are set within Asterisk.
====================================================================== 

---------------------------------------------------------------------- 
 (0114351) tilghman (administrator) - 2009-11-29 22:55
 https://issues.asterisk.org/view.php?id=16343#c114351 
---------------------------------------------------------------------- 
1) Instead of defining a new function called cli_yesno, make it a macro
instead.
2) Tabs are verboten within lines.  Use spaces within lines, tabs only at
the beginning of lines.  Tabs are ESPECIALLY verboten within constant
strings.
3) You have introduced a rather major memory leak with
manager_channelvars.  Additionally, you have violated the coding guidelines
by causing a variable declaration to no longer be at the beginning of a
code block. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-29 22:55 tilghman       Note Added: 0114351                          
======================================================================




More information about the asterisk-bugs mailing list