[asterisk-bugs] [Asterisk 0016240]: [patch] QUEUE_MEMBER(..., free) counts wrapping-up agents as available

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16240 
====================================================================== 
Reported By:                kkm
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16240
Category:                   Applications/app_queue
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Asterisk Version:           1.6.2.0-rc5 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-13 01:34 CST
Last Modified:              2009-11-29 08:49 CST
====================================================================== 
Summary:                    [patch] QUEUE_MEMBER(...,free) counts wrapping-up
agents as available
Description: 
the QUEUE_MEMBER dialplan function can return total members, logged-in
members and "free" members count. A member is counted as "free" immediately
after his call ends, even though its wrap-up time, if specified in
queues.conf, has not yet expired, and the queue will not actually route a
call to it.
====================================================================== 

---------------------------------------------------------------------- 
 (0114343) kkm (reporter) - 2009-11-29 08:49
 https://issues.asterisk.org/view.php?id=16240#c114343 
---------------------------------------------------------------------- 
Just uploaded a patch against current trunk. Yes, there are significant
differences in code: documentation has been moved to XML chunk in
commentary, and a function call to destroy an iterator is now required. It
is good that it did not apply as is, as that would probably cause a leak of
iterators.

This probably means also that the patches that I submitted over last
months are probably stale now -- and they are nowhere in sight from the
front of the queue, or however they are sorted. They are "ready for
testing" for months. That, in turn, likely indicates that this is not the
right way to submit code changes, even if serious bug fixes, as it takes
too long for them to be any useful. Should I rather directly communicate
with module maintainers (again, I am only assuming that there are module
maintainers)?

I am not actively developing asterisk, just running servers, and fixing
bugs and annoyances as they arise. I thought it would be a win-win if I
send the patches in: less patch maintenance for me, less bugs for you; but
-- in the end, that was only my unfounded assumption. Should I really even
try to send in fixes? Is that really going to help anyone out there? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-29 08:49 kkm            Note Added: 0114343                          
======================================================================