[asterisk-bugs] [Asterisk 0016268]: [patch] Last line of SDP is not being parsed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16268 
====================================================================== 
Reported By:                sgimeno
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   16268
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-425 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 230420 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-18 03:59 CST
Last Modified:              2009-11-23 09:39 CST
====================================================================== 
Summary:                    [patch] Last line of SDP is not being parsed
Description: 
I observed this behavior when I put a call in hold and no musiconhold was
played. The last line of the SDP of the "hold" re-INVITE was a=sendonly.
By checking the logs it can be seen that the last line of the SDP is not
processed in the process_sdp function.
I made a simple modification in the chan_sip.c (see attached patch) in
order to parse the last line and the issue was solved.
====================================================================== 

---------------------------------------------------------------------- 
 (0114141) svnbot (reporter) - 2009-11-23 09:39
 https://issues.asterisk.org/view.php?id=16268#c114141 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 230876

_U  trunk/

------------------------------------------------------------------------
r230876 | kpfleming | 2009-11-23 09:39:55 -0600 (Mon, 23 Nov 2009) | 12
lines

Blocked revisions 230875 via svnmerge

........
  r230875 | kpfleming | 2009-11-23 09:31:02 -0600 (Mon, 23 Nov 2009) | 7
lines
  
  When 'sip set debug' is enabled, and the last line of an incoming SIP
message
  is not properly newline terminated, ensure that that line is included in
the
  debug output.
  
  (part of issue https://issues.asterisk.org/view.php?id=16268)
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230876 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-23 09:39 svnbot         Checkin                                      
2009-11-23 09:39 svnbot         Note Added: 0114141                          
======================================================================