[asterisk-bugs] [Asterisk 0016268]: [patch] Last line of SDP is not being parsed

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16268 
====================================================================== 
Reported By:                sgimeno
Assigned To:                kpfleming
====================================================================== 
Project:                    Asterisk
Issue ID:                   16268
Category:                   Channels/chan_sip/General
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     closed
Asterisk Version:           SVN 
JIRA:                       SWP-425 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  1.4  
SVN Revision (number only!): 230420 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-18 03:59 CST
Last Modified:              2009-11-23 08:28 CST
====================================================================== 
Summary:                    [patch] Last line of SDP is not being parsed
Description: 
I observed this behavior when I put a call in hold and no musiconhold was
played. The last line of the SDP of the "hold" re-INVITE was a=sendonly.
By checking the logs it can be seen that the last line of the SDP is not
processed in the process_sdp function.
I made a simple modification in the chan_sip.c (see attached patch) in
order to parse the last line and the issue was solved.
====================================================================== 

---------------------------------------------------------------------- 
 (0114137) svnbot (reporter) - 2009-11-23 08:28
 https://issues.asterisk.org/view.php?id=16268#c114137 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 230796

_U  branches/1.6.2/
U   branches/1.6.2/channels/chan_sip.c

------------------------------------------------------------------------
r230796 | kpfleming | 2009-11-23 08:28:38 -0600 (Mon, 23 Nov 2009) | 19
lines

Merged revisions 230773 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

................
  r230773 | kpfleming | 2009-11-23 08:15:48 -0600 (Mon, 23 Nov 2009) | 12
lines
  
  Merged revisions 230772 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.4
  
  ........
    r230772 | kpfleming | 2009-11-23 08:13:56 -0600 (Mon, 23 Nov 2009) | 5
lines
    
    Ensure that SDP parsing does not ignore the last line of the SDP.
    
    (closes issue https://issues.asterisk.org/view.php?id=16268)
    Reported by: sgimeno
  ........
................

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=230796 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-23 08:28 svnbot         Checkin                                      
2009-11-23 08:28 svnbot         Note Added: 0114137                          
======================================================================