[asterisk-bugs] [Asterisk 0016296]: menuselect.makeopts: does not properly unselect an option with a leading - (minus)

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16296 
====================================================================== 
Reported By:                abelbeck
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16296
Category:                   Sounds
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
Asterisk Version:           1.4.27 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-20 15:41 CST
Last Modified:              2009-11-20 17:13 CST
====================================================================== 
Summary:                    menuselect.makeopts: does not properly unselect an
option with a leading - (minus)
Description: 
The main asterisk Makefile no longer contains the line:

.PHONY: menuselect.makeopts

So the section...
menuselect.makeopts: menuselect/menuselect menuselect-tree etc...
  menuselect/menuselect --check-deps $@ $(GLOBAL_MAKEOPTS)
$(USER_MAKEOPTS)

is now only called once.  The problem is if either GLOBAL_MAKEOPTS or
USER_MAKEOPTS contains an option to be un-selected from the default by
placing a - (minus) in front of the option, this no longer works.  (See
Additional Information)

My fix is to call menuselect/menuselect twice, first to create a default
menuselect.makeopts file and second to check/un-check any GLOBAL_MAKEOPTS
or USER_MAKEOPTS options relative to the default options.

menuselect.makeopts: menuselect/menuselect menuselect-tree etc...
  menuselect/menuselect --check-deps $@
  menuselect/menuselect --check-deps $@ $(GLOBAL_MAKEOPTS)
$(USER_MAKEOPTS)

This fix has been tested and works.
====================================================================== 

---------------------------------------------------------------------- 
 (0114089) pprindeville (reporter) - 2009-11-20 17:13
 https://issues.asterisk.org/view.php?id=16296#c114089 
---------------------------------------------------------------------- 
That causes everyone building Asterisk to change how they do it.

I'm thinking that fixing the regression wouldn't cause anyone to have to
change anything (except the Asterisk makefile, which broke).

Right?

What am I missing? 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-20 17:13 pprindeville   Note Added: 0114089                          
======================================================================