[asterisk-bugs] [Asterisk 0016289]: core show function CDR reports wrong disposition values

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16289 
====================================================================== 
Reported By:                wdoekes
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16289
Category:                   Functions/func_cdr
Reproducibility:            always
Severity:                   text
Priority:                   normal
Status:                     feedback
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-20 04:40 CST
Last Modified:              2009-11-20 08:30 CST
====================================================================== 
Summary:                    core show function CDR reports wrong disposition
values
Description: 
When running:

exten => s,1,Answer()
exten => s,n,NoOp(exten => _X.,n,NoOp(QUEUE_ANS: ${CDR(disposition)} /
${CDR(disposition,u)})

I get:

voip-test*CLI> 
<...snip...>
    -- Executing [s at pi_incoming_queue:2] NoOp("SIP/1.2.3.4-0241c1e0",
"QUEUE_ANS: ANSWERED / 8") in new stack
<...snip...>


When checking the function description, I get:

voip-test*CLI> core show function CDR
<...snip...>
   raw values for disposition:
       1 = NO ANSWER
       2 = BUSY
       3 = FAILED
       4 = ANSWERED
<...snip...>


This means that the raw disposition values in the documentation are wrong,
right?

According to svn blame it has always been like this in
include/asterisk/cdr.h:
#define AST_CDR_FAILED                          (1 << 0)
#define AST_CDR_BUSY                            (1 << 1)
#define AST_CDR_NOANSWER                        (1 << 2)
#define AST_CDR_ANSWERED                        (1 << 3)


Patch for 1.4:

<inline patch removed by lmadsen>

Patch for 1.6-svn:

<inline patch removed by lmadsen>



Regards,
Walter Doekes
OSSO B.V.
====================================================================== 

---------------------------------------------------------------------- 
 (0114039) lmadsen (administrator) - 2009-11-20 08:30
 https://issues.asterisk.org/view.php?id=16289#c114039 
---------------------------------------------------------------------- 
Unfortunately we can't accept inline patches as that circumvents the
licensing system we have in place.

Would you mind signing the electronic license (if you haven't already)?
There is a link in the main header of this page that will allow you to
submit it online.

Once you've done that, could you upload your patch as an attachment to
this issue?

Thanks for the contribution! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-20 08:30 lmadsen        Note Added: 0114039                          
2009-11-20 08:30 lmadsen        Status                   new => feedback     
======================================================================