[asterisk-bugs] [Asterisk 0015223]: [patch] New asterisk function REPLACE

[Asterisk Bug Tracker]

The following issue requires your FEEDBACK. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15223 
====================================================================== 
Reported By:                ajohnson
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15223
Category:                   Functions/func_strings
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     feedback
Target Version:             1.8
Asterisk Version:           SVN 
JIRA:                       SWP-283 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 197994 
Request Review:              
====================================================================== 
Date Submitted:             2009-05-29 12:02 CDT
Last Modified:              2009-11-11 11:13 CST
====================================================================== 
Summary:                    [patch] New asterisk function REPLACE
Description: 
[Synopsis]
Replace a set of characters with another character in a given string


[Description]
Iterates through a string replacing all the <find-chars> with
<replace-char>.
NOTE: <replace-char> may be either empty or contain one character

[Syntax]
REPLACE(find-chars,replace-char,string)

====================================================================== 

---------------------------------------------------------------------- 
 (0113665) tilghman (administrator) - 2009-11-11 11:13
 https://issues.asterisk.org/view.php?id=15223#c113665 
---------------------------------------------------------------------- 
The format of this patch fails review.

1) Lines must be indented with tabs, not spaces.
2) The documentation specifies pipes as delimiters, yet commas are
delimiters.
3) In addition, I'd strongly recommend that you use the C function
strchr(3) to do your string searches for characters to replace and use
ast_get_encoded_str(), to allow nonprintable characters and commas to be
specified in the first two fields. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-11 11:13 tilghman       Note Added: 0113665                          
2009-11-11 11:13 tilghman       Status                   ready for testing =>
feedback
======================================================================