[asterisk-bugs] [Asterisk 0016123]: [patch] ExternalIVR trapping non-existant files does not work

[Asterisk Bug Tracker]

The following issue has been ASSIGNED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16123 
====================================================================== 
Reported By:                thedavidfactor
Assigned To:                thedavidfactor
====================================================================== 
Project:                    Asterisk
Issue ID:                   16123
Category:                   Applications/app_externalivr
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.1.6 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-10-23 16:24 CDT
Last Modified:              2009-11-10 12:54 CST
====================================================================== 
Summary:                    [patch] ExternalIVR trapping non-existant files does
not work
Description: 
The documentation for ExternalIVR states:

The 'S' command checks to see if there is a playable audio file with the
specified name, and if so, clear's the generator's playlist and places the
file onto the list. Note that the playability check does not take into
account transcoding requirements, so it is possible for the file to not be
played even though it was found. If the file cannot be found, a 'Z' event
(see above) will be sent to the child.

And:

The 'A' command checks to see if there is a playable audio file with
the specified name, and if so, adds it to the generator's
playlist. The same playability and exception rules apply as for the
'S' command.

This doesn't work. Nothing is returned if the files doesn't exist. I
tracked that down to conditional test that was not valid:

727: if (ast_fileexists(&input[2], NULL, u->chan->language) == -1) {

However fixing that lead to a second problem, ExternalIVR would then
attempt to play the file "exception" so I modified it further to not
attempt to play the file if the conditional test on line 727 failed. In
addition I added the missing file information to the data of the returned
eivr_event because I felt that it was in the spirit of the other return
values related to playing files. (F & D specifically)
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-10 12:54 thedavidfactor Status                   ready for review =>
assigned
2009-11-10 12:54 thedavidfactor Assigned To               => thedavidfactor  
======================================================================