[asterisk-bugs] [Asterisk 0014621]: [patch] extend / rewrite volume function and audiohook

[Asterisk Bug Tracker]

The following issue has been UPDATED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14621 
====================================================================== 
Reported By:                KNK
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14621
Category:                   Functions/func_volume
Reproducibility:            have not tried
Severity:                   tweak
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-07 23:58 CST
Last Modified:              2009-11-10 11:31 CST
====================================================================== 
Summary:                    [patch] extend / rewrite volume function and
audiohook
Description: 
the newly added in 1.6.1 function volume creates its own audiohook instead
of using the builtin one and also (silently) listens for DTMF to update the
volume. This patch adds the DTMF functionality to the bultin audiohook and
makes the function using it instead of creating its own and the ability to
set custom DTMF and to read the values.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0014789 [patch] add possibility to read
====================================================================== 

---------------------------------------------------------------------- 
 (0113581) KNK (reporter) - 2009-11-10 10:51
 https://issues.asterisk.org/view.php?id=14621#c113581 
---------------------------------------------------------------------- 
no the crash was a different issue. There is still a possibility (without
this change) for a crash if the callback is called with a NULL frame, which
may happen when a previous audiohook in the list have failed.
Maybe it will be better to restore the previous frame instead of freeing
it on error, but not sure ... in either case checking for NULL frame won't
hurt here 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-10 10:51 KNK            Note Added: 0113581                          
======================================================================