[asterisk-bugs] [Asterisk 0014673]: [patch] Missing mute facility

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14673 
====================================================================== 
Reported By:                Nick_Lewis
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14673
Category:                   Channels/chan_alsa
Reproducibility:            always
Severity:                   feature
Priority:                   normal
Status:                     ready for testing
Target Version:             Feature Tracker
Asterisk Version:           1.6.0.3 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-03-16 10:18 CDT
Last Modified:              2009-11-09 12:40 CST
====================================================================== 
Summary:                    [patch] Missing mute facility
Description: 
chan_oss.c has a mute facility for the console phone. This facility is
missing from chan_alsa.c. Please find attached a patch that adds the
facility. 

The patch permits the initial mute state to be defined in the conf file.
This is useful in conjunction with auto-answer for call screening purposes.
Also the patch ensures that the console will not attach to a sound capture
port if a noaudiocapture parameter is set in the conf file. This permits
the console phone to be connected to a public address system which has no
return audio path. It also frees up the sound capture port for streaming or
live music on hold uses.


====================================================================== 

---------------------------------------------------------------------- 
 (0113447) qwell (administrator) - 2009-11-09 12:40
 https://issues.asterisk.org/view.php?id=14673#c113447 
---------------------------------------------------------------------- 
Patch 3 looks much better, thank you.

I could probably commit this as-is, but I wanted to propose an idea
first.

Do we really need noaudiocapture?  The reason for it seems to be so that
the system doesn't keep the capture device open.  I don't think that's
really a problem though.  With a sane ALSA configuration, multiple
applications can open the same device (as long as you aren't trying to
access the hardware directly - using "default" will usually make this "Just
Work").

Thoughts?  I'd be happy to upload a version of the patch with those
changes, so you could test them (and verify that it works the way I
asserted). 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-09 12:40 qwell          Note Added: 0113447                          
======================================================================