[asterisk-bugs] [Asterisk 0015588]: [patch] crash in chanspy on hangup - locked mutex '&chanspy_ds.lock'

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15588 
====================================================================== 
Reported By:                zerohalo
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   15588
Category:                   Applications/app_chanspy
Reproducibility:            have not tried
Severity:                   crash
Priority:                   normal
Status:                     ready for review
Asterisk Version:           SVN 
JIRA:                       SWP-279 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-07-27 11:24 CDT
Last Modified:              2009-11-09 08:21 CST
====================================================================== 
Summary:                    [patch] crash in chanspy on hangup - locked mutex
'&chanspy_ds.lock'
Description: 
random crash in 1.4.24.1 CLI below, bt attached.

-- Packet2Packet bridging SIP/XXXX-XXXX-0a39f098 and
SIP/gateway1-0949da50
-- <SIP/XX.XX.XX.XX-b7c008f8> Playing 'digits/6' (language
'en')
-- <SIP/XX.XX.XX.XX-b7dbcb80> Playing 'beep' (language
'en')
-- Nobody picked up in 25000 ms
== Done Spying on channel SIP/XXXX-XXXX-0957f6b8
[Jul 27 10:36:21] ERROR[7010]:
/usr/src/asterisk/asterisk-1.4.24/include/asterisk/lock.h:320
__ast_pthread_mutex_destroy: app_chanspy.c line 683 (common_exec):
Error: attempt to destroy locked mutex '&chanspy_ds.lock'.

======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
related to          0015414 crash: &quot;chan_sip.c&quot;, lineno=3910
====================================================================== 

---------------------------------------------------------------------- 
 (0113405) svnbot (reporter) - 2009-11-09 08:21
 https://issues.asterisk.org/view.php?id=15588#c113405 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 228827

U   branches/1.4/include/asterisk/lock.h

------------------------------------------------------------------------
r228827 | mnicholson | 2009-11-09 08:21:53 -0600 (Mon, 09 Nov 2009) | 8
lines

Perform limited bounds checking when destroying ast_mutex_t structures to
make sure we don't try to use negative indices.

(closes issue https://issues.asterisk.org/view.php?id=15588)
Reported by: zerohalo
Patches:
      20090820__issue15588.diff.txt uploaded by tilghman (license 14)
Tested by: zerohalo

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228827 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-09 08:21 svnbot         Note Added: 0113405                          
======================================================================