[asterisk-bugs] [Asterisk 0016176]: OpenSolaris Build Problem with editline

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16176 
====================================================================== 
Reported By:                bklang
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   16176
Category:                   Core/Portability
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     new
Asterisk Version:           1.6.1.6 
JIRA:                        
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-11-03 23:32 CST
Last Modified:              2009-11-06 20:56 CST
====================================================================== 
Summary:                    OpenSolaris Build Problem with editline
Description: 
This is a continuation of the suspended bug
https://issues.asterisk.org/view.php?id=13704.  I did not see a way to
comment on that bug, so I have opened this one. This bug is observed
against 1.6.1.6.

Most build issues reported in https://issues.asterisk.org/view.php?id=13704
appear to be resolved, but at least
this one regarding editline is still present:

In file included from sig.h:47,
                 from el.h:107,
                 from common.c:51,
                 from editline.c:4:
/usr/include/signal.h:95: error: syntax error before '*' token
make[2]: *** [editline.o_a] Error 1
make[1]: *** [editline/libedit.a] Error 2
make: *** [main] Error 2


A full log of the build output is attached.
======================================================================
Relationships       ID      Summary
----------------------------------------------------------------------
has duplicate       0014517 [patch] signals.h - syntax error before...
====================================================================== 

---------------------------------------------------------------------- 
 (0113361) bklang (reporter) - 2009-11-06 20:56
 https://issues.asterisk.org/view.php?id=16176#c113361 
---------------------------------------------------------------------- 
I did a comparison of the sources between Asterisk trunk and branch/1.6.1. 
I found the following macros were defined in trunk, but not in 1.6.1:

(near line 225 of asterisk-trunk/include/asterisk/utils.h)
#undef MIN
#define MIN(a, b) ({ typeof(a) __a = (a); typeof(b) __b = (b); ((__a >
__b) ? __b : __a);})
#undef MAX
#define MAX(a, b) ({ typeof(a) __a = (a); typeof(b) __b = (b); ((__a <
__b) ? __b : __a);})


Adding these two macros to 1.6.1 allows a successful build on OpenSolaris. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-06 20:56 bklang         Note Added: 0113361                          
======================================================================