[asterisk-bugs] [Asterisk 0016167]: Chaspy always active Option ´o´

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=16167 
====================================================================== 
Reported By:                marhbere
Assigned To:                jpeeler
====================================================================== 
Project:                    Asterisk
Issue ID:                   16167
Category:                   Applications/app_chanspy
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     closed
Target Version:             1.6.0.16
Asterisk Version:           SVN 
JIRA:                       SWP-331 
Regression:                 No 
Reviewboard Link:            
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!): 226533 
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-11-02 15:45 CST
Last Modified:              2009-11-05 15:33 CST
====================================================================== 
Summary:                    Chaspy  always active Option ´o´
Description: 
In Revision: 224179 were try aply the option o, but in the IF always take
the true : So only heard the outbound audio.

	if (ast_test_flag(chan, OPTION_READONLY)) {
		/* Option 'o' was set, so don't mix channel audio */
		f = ast_audiohook_read_frame(&csth->spy_audiohook, samples,
AST_AUDIOHOOK_DIRECTION_READ, AST_FORMAT_SLINEAR);
	} else {
		f = ast_audiohook_read_frame(&csth->spy_audiohook, samples,
AST_AUDIOHOOK_DIRECTION_BOTH, AST_FORMAT_SLINEAR);
	}

====================================================================== 

---------------------------------------------------------------------- 
 (0113237) svnbot (reporter) - 2009-11-05 15:33
 https://issues.asterisk.org/view.php?id=16167#c113237 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 228195

_U  branches/1.6.2/
U   branches/1.6.2/apps/app_chanspy.c

------------------------------------------------------------------------
r228195 | jpeeler | 2009-11-05 15:33:02 -0600 (Thu, 05 Nov 2009) | 17
lines

Merged revisions 228189 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/trunk

........
  r228189 | jpeeler | 2009-11-05 15:23:06 -0600 (Thu, 05 Nov 2009) | 11
lines
  
  Fix the fix for chanspy option o 
  
  In 224178, I assumed the uploaded patch was correct as it had received
positive
  feedback. The flags were being checked in the incorrect location. Upon
testing
  the fix this time it was also found that the flags from the dialplan
weren't
  being copied to the chanspy_translation_helper.
  
  (closes issue https://issues.asterisk.org/view.php?id=16167)
  Reported by: marhbere
........

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=228195 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-11-05 15:33 svnbot         Checkin                                      
2009-11-05 15:33 svnbot         Note Added: 0113237                          
======================================================================