[asterisk-bugs] [Asterisk 0014849]: [patch] SendFax function not working as expected on > 1.6.0.7

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14849 
====================================================================== 
Reported By:                afosorio
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   14849
Category:                   Channels/chan_sip/T.38
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     new
Target Version:             1.6.0.10
Asterisk Version:           1.6.0.7 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases): 1.6.0 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-04-07 15:51 CDT
Last Modified:              2009-05-30 05:48 CDT
====================================================================== 
Summary:                    [patch] SendFax function not working as expected on
> 1.6.0.7
Description: 
When trying to send a fax via callfile using T.38 in asterisk version
1.6.0.5 it works fine, but after upgrading to asterisk 1.6.0.7 or newer it
does not work. When receiving re-INVITE from media gateway (Cisco AS-5400)
Asterisk ends call answering 488 Not acceptable here. I am running Asterisk
under Debian kernel 2.6.18-6-686. I am attaching captures both for scenario
which works and scenario which does not work. 
====================================================================== 

---------------------------------------------------------------------- 
 (0105785) dimas (reporter) - 2009-05-30 05:48
 https://issues.asterisk.org/view.php?id=14849#c105785 
---------------------------------------------------------------------- 
Ivan,
I believe your patch is not very correct: you can only suggest chan_sip to
initiate or accept T38 (both of which is done with
AST_T38_REQUEST_NEGOTIATE) and should wait for the confirmatiion from the
chan_sip (which is AST_T38_NEGOTIATED).

If you look at the code, you will find that actually chan_sip handles
AST_T38_REQUEST_NEGOTIATE and AST_T38_NEGOTIATED control frames exactly the
same way - this is why your patch works too. However I believe, the correct
approach is described above.

I'm attaching patch however I did not test it. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-30 05:48 dimas          Note Added: 0105785                          
======================================================================