[asterisk-bugs] [Asterisk 0014412]: [patch] 1.6.1 Choppy sound in Dual Xeon 2.8 GHz

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=14412 
====================================================================== 
Reported By:                dome
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   14412
Category:                   Resources/General
Reproducibility:            always
Severity:                   block
Priority:                   normal
Status:                     ready for testing
Target Version:             1.6.1.1
Asterisk Version:           1.6.1.0 
Regression:                 Yes 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-02-05 10:22 CST
Last Modified:              2009-05-29 15:07 CDT
====================================================================== 
Summary:                    [patch] 1.6.1 Choppy sound in Dual Xeon 2.8 GHz
Description: 
I found choppy sound when use 1.6.1 in dual xeon cpu Server 
But 1.6.0 and trunk work fine. i try on 2 server found same problem.
(Debian Lenny and Ubuntu hardy)
I try all codec still got problem.
============= CPU =================
vendor_id	: GenuineIntel
cpu family	: 15
model		: 2
model name	: Intel(R) Xeon(TM) CPU 2.80GHz
stepping	: 5
cpu MHz		: 2791.116
cache size	: 512 KB
physical id	: 3
siblings	: 2
core id		: 0
cpu cores	: 1
fdiv_bug	: no
hlt_bug		: no
f00f_bug	: no
coma_bug	: no
fpu		: yes
fpu_exception	: yes
cpuid level	: 2
wp		: yes
flags		: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat
pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe pebs bts sync_rdtsc
cid xtpr
bogomips	: 5582.22
clflush size	: 64

====================================================================== 

---------------------------------------------------------------------- 
 (0105753) svnbot (reporter) - 2009-05-29 15:07
 https://issues.asterisk.org/view.php?id=14412#c105753 
---------------------------------------------------------------------- 
Repository: asterisk
Revision: 198146

U   trunk/res/res_timing_pthread.c

------------------------------------------------------------------------
r198146 | russell | 2009-05-29 15:06:59 -0500 (Fri, 29 May 2009) | 38
lines

Resolve issues with choppy sound when using res_timing_pthread.

The situation that caused this problem was when continuous mode was being
turned on and off while a rate was set for a timing interface.  A very
easy
way to replicate this bug was to do a Playback() from behind a Local
channel.
In this scenario, a rate gets set on the channel for doing file playback.
At the same time, continuous mode gets turned on and off about every 20 ms
as frames get queued on to the PBX side channel from the other side of the
Local channel.

Essentially, this module treated continuous mode and a set rate as
mutually
exclusive states for the timer to be in.  When I dug deep enough, I
observed
the following pattern:

   1) Set timer to tick every 20 ms.
   2) Wait almost 20 ms ...
   3) Continuous mode gets turned on for a queued up frame
   4) Continuous mode gets turned off
   5) The timer goes back to its tick per 20 ms. state but starts counting
      at 0 ms.
   6) Goto step 2.

Sometimes, res_timing_pthread would make it 20 ms and produce a timer
tick,
but not most of the time.  This is what produced the choppy sound (or
sometimes
no sound at all).

Now, the module treats continuous mode and a set rate as completely
independent
timer modes.  They can be enabled and disabled independently of each other
and
things work as expected.


(closes issue https://issues.asterisk.org/view.php?id=14412)
Reported by: dome
Patches:
      issue14412.diff.txt uploaded by russell (license 2)
      issue14412-1.6.1.0.diff.txt uploaded by russell (license 2)
Tested by: DennisD, russell

------------------------------------------------------------------------

http://svn.digium.com/view/asterisk?view=rev&revision=198146 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-29 15:07 svnbot         Note Added: 0105753                          
======================================================================