[asterisk-bugs] [Asterisk 0015156]: [patch] When lastms was added to realtime_update_peer in chan_sip the necessary ldap changes were not made

[Asterisk Bug Tracker]

The following issue has been RESOLVED. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15156 
====================================================================== 
Reported By:                jcovert
Assigned To:                suretec
====================================================================== 
Project:                    Asterisk
Issue ID:                   15156
Category:                   Resources/res_config_ldap
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     resolved
Asterisk Version:           1.6.0.9 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
Resolution:                 fixed
Fixed in Version:           
====================================================================== 
Date Submitted:             2009-05-19 12:31 CDT
Last Modified:              2009-05-28 05:43 CDT
====================================================================== 
Summary:                    [patch] When lastms was added to
realtime_update_peer in chan_sip the necessary ldap changes were not made
Description: 
When lastms was added to realtime_update_peer in chan_sip the necessary
ldap changes were not made

In the process of fixing issue https://issues.asterisk.org/view.php?id=14196,
calls to realtime_update_peer were
added to chan_sip to store 'lastms' (the number of milliseconds for the
last qualify).  This causes constant error messages:

  [May 19 11:56:01] ERROR[6670]: res_config_ldap.c:1292 update_ldap:
  Couldn't modify dn:uid=sipaccount009,ou=people,dc=company,dc=net
because
  Undefined attribute type

Whenever a new item is added to realtime, it is necessary to update the
ldap definitions to support it.  I propose making the following changes
required to eliminate this error:

1. Modify contrib/scripts/asterisk.ldap-schema as follows:

a. update version number and list this bug number in the changes.
b. Add objectIdentifier AstAccountLastQualifyMilliseconds AstAttrType:49
c. Add
  attributetype ( AstAccountLastQualifyMilliseconds 
	NAME 'AstAccountLastQualifyMilliseconds'
	DESC 'Asterisk Account Last Qualify Milliseconds'
	EQUALITY caseIgnoreMatch
	SUBSTR caseIgnoreSubstringsMatch
	SYNTAX 1.3.6.1.4.1.1466.115.121.1.15)
d. Add AstAccountLastQualifyMilliseconds to objectclass AsteriskSIPUser
and for completeness to objectclass AsteriskIAXUser even though not yet
used.

2. Modify configs/res_ldap.conf.sample to include
     lastms = AstAccountLastQualifyMilliseconds
  in the Sip Users Table

3. Modify SOMETHING, somewhere (chan_sip.c if no one suggests a better
place, or maybe in more than one place) to refer future developers to the
need to update these two files whenever adding new realtime updates.

I expect to submit patches within the next two or three days once I have
actually tested this; I cannot do this while production is running today.

Regards/john

====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-28 05:43 svnbot         Status                   assigned => resolved
2009-05-28 05:43 svnbot         Resolution               open => fixed       
======================================================================