[asterisk-bugs] [Asterisk 0015025]: [patch] Functions INC and DEC

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15025 
====================================================================== 
Reported By:                greenfieldtech
Assigned To:                tilghman
====================================================================== 
Project:                    Asterisk
Issue ID:                   15025
Category:                   Functions/func_math
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     acknowledged
Asterisk Version:           SVN 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 191919M 
Request Review:              
====================================================================== 
Date Submitted:             2009-05-03 20:30 CDT
Last Modified:              2009-05-26 09:38 CDT
====================================================================== 
Summary:                    [patch] Functions INC and DEC
Description: 
Over the course of time, developing Asterisk dialplans becomes fairly
cumbersome, especially when writing While() loops in the dialplan. Mainly,
when we want to iterate a few times, the ever annoying Set(Var=$[${Var} +
1]) is really annoying.
INCrement and DECrement follow the old PASCAL functions, allowing to
increment and decrement a variable.

The functions are built to handle both numeric and alpha-numeric values.
If an alpha-numeric value is given, the functions will simply bail out and
issue a LOG_NOTICE accordingly.

In order to implement this, i've added some functionality to func_math.c
and added a new ast_is_numeric function to strings.h

Please find attached patches for TRUNK.
====================================================================== 

---------------------------------------------------------------------- 
 (0105416) lmadsen (administrator) - 2009-05-26 09:38
 https://issues.asterisk.org/view.php?id=15025#c105416 
---------------------------------------------------------------------- 
Not sure if this is just a typo, or how you are actually wanting this to
work, but I don't like this format in the dialplan:

exten => _X.,n,While($[DEC(MyVar) > 0])

I'd expect to do:

exten => _X.,n,While($[${DEC(MyVar)} > 0])

The ${DEC(MyVar)} should decrement the number from ${MyVar} and return the
result.

Like I said, this may be exactly how it works now, but could just be a
typo in the dialplan example.

BTW: As someone who does a lot of loops, I like this! 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-26 09:38 lmadsen        Note Added: 0105416                          
======================================================================