[asterisk-bugs] [Asterisk 0015181]: [patch] file convert leaks input file descriptor

[Asterisk Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://issues.asterisk.org/view.php?id=15181 
====================================================================== 
Reported By:                jkroon
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   15181
Category:                   Resources/res_convert
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.6.0.9 
Regression:                 No 
SVN Branch (only for SVN checkouts, not tarball releases): N/A 
SVN Revision (number only!):  
Request Review:              
====================================================================== 
Date Submitted:             2009-05-22 09:18 CDT
Last Modified:              2009-05-25 06:03 CDT
====================================================================== 
Summary:                    [patch] file convert leaks input file descriptor
Description: 
when issueing a file convert it seems that asterisk is leaking the input
file descriptor.  As a test I copied a .g729 file into /tmp
(/tmp/test.g729), the rest follows:

gabriel ~ # ls -l /tmp/test.* 
-rw-r--r-- 1 root root 3380 May 22 16:10 /tmp/test.g729
gabriel ~ # ls -l /proc/$(pidof asterisk)/fd/ | grep test 
gabriel ~ # asterisk -rx "file convert /tmp/test.g729 /tmp/test.wav"
Converted /tmp/test.g729 to /tmp/test.wav in 12ms
gabriel ~ # ls -l /proc/$(pidof asterisk)/fd/ | grep test
lrwx------ 1 asterisk asterisk 64 May 22 16:10 179 -> /tmp/test.g729
gabriel ~ # ls -l /tmp/test.*
-rw-r--r-- 1 root     root      3380 May 22 16:10 /tmp/test.g729
-rw-r--r-- 1 asterisk asterisk 54124 May 22 16:12 /tmp/test.wav
gabriel ~ # 

I'll take a peek at the code a little later, for now I just need to have
it reported.  I don't think this was the case in 1.6.0.3 but I'll need to
go find an installation to confirm.
====================================================================== 

---------------------------------------------------------------------- 
 (0105367) jkroon (reporter) - 2009-05-25 06:03
 https://issues.asterisk.org/view.php?id=15181#c105367 
---------------------------------------------------------------------- 
Hi,

I just attached a patch that "cures" the bad behavior for me, I have
(however) no idea about the correctness of the patch.  Please audit and
provide feedback.  This is a rather critical issue for me at least. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-05-25 06:03 jkroon         Note Added: 0105367                          
======================================================================